Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7f9a39d1d1557afa09aa8b657a40f0c03e621cfa.camel@sipsolutions.net>
Subject: Re: Aw: Re:  Re: help for driver porting - missing member
 preset_chandef in struct wireless_dev
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Frank Wunderlich <frank-w@public-files.de>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Date:   Mon, 22 Aug 2022 21:19:38 +0200
In-Reply-To: <trinity-94aeced0-7aab-4359-9c74-1616a17464bd-1661187572028@3c-app-gmx-bap06>
References: <trinity-de687d18-b2a2-4cde-9383-a4d6ddba6a77-1661177057496@3c-app-gmx-bap06>
         <b081ef6eb978070740f31f48a1f4be1807f51168.camel@sipsolutions.net>
         <trinity-64c5eed8-8b6b-4b33-9204-89aff4fce7db-1661186571606@3c-app-gmx-bap06>
         <51a1b56a4d9ed825cb47cf364c5bd72f3338a1a6.camel@sipsolutions.net>
         <trinity-94aeced0-7aab-4359-9c74-1616a17464bd-1661187572028@3c-app-gmx-bap06>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-08-22 at 18:59 +0200, Frank Wunderlich wrote:
> > Gesendet: Montag, 22. August 2022 um 18:43 Uhr
> > Von: "Johannes Berg" <johannes@sipsolutions.net>
>=20
> > On Mon, 2022-08-22 at 18:42 +0200, Frank Wunderlich wrote:
>=20
> > > thanks for response, commented out the use of the member and the
> > > wdev
> > > assignment as it was then unused
> > > can you tell me which api-call this should be?
> > > i just want to make sure this is really done as i up-ported the
> > > driver
> > > from 4.9, so if the api-call was introduced later it is maybe
> > > missing.
> >=20
> > No sorry, I don't know how the driver was/is using it, so I can't
> > tell
> > you how to replace it.
>=20
> can you give me possible calls (if there are multiple candidates)
> which may set the channel (without mesh)
> for me to check or maybe implement?

Well it seems to access it inside the start_ap callback, so it should
just check the configuration instea