Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 07:59:33 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     duoming@zju.edu.cn
Cc:     Brian Norris <briannorris@chromium.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        amit karwar <amitkarwar@gmail.com>,
        Ganapathi Bhat <ganapathi017@gmail.com>,
        Sharvari Harisangam <sharvari.harisangam@nxp.com>,
        Xinming Hu <huxinming820@gmail.com>, kvalo@kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        "<netdev@vger.kernel.org>" <netdev@vger.kernel.org>
Subject: Re: [PATCH v8 0/2] Add new APIs of devcoredump and fix bugs
Message-ID: <YwcPxT2JLQHXbdFI@kroah.com>
References: <cover.1661252818.git.duoming@zju.edu.cn>
 <CA+ASDXNf5JV9mj8mbm1OGZ_zd4d8srFc=E++Amg4MoQjqjS_TA@mail.gmail.com>
 <27a2a8a7.99f01.182d2758bc9.Coremail.duoming@zju.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <27a2a8a7.99f01.182d2758bc9.Coremail.duoming@zju.edu.cn>
Precedence: bulk

On Thu, Aug 25, 2022 at 08:44:55AM +0800, duoming@zju.edu.cn wrote:
> Hello,
> 
> On Wed, 24 Aug 2022 13:42:09 -0700 Brian Norris wrote:
> 
> > On Tue, Aug 23, 2022 at 4:21 AM Duoming Zhou <duoming@zju.edu.cn> wrote:
> > >
> > > The first patch adds new APIs to support migration of users
> > > from old device coredump related APIs.
> > >
> > > The second patch fix sleep in atomic context bugs of mwifiex
> > > caused by dev_coredumpv().
> > >
> > > Duoming Zhou (2):
> > >   devcoredump: add new APIs to support migration of users from old
> > >     device coredump related APIs
> > >   mwifiex: fix sleep in atomic context bugs caused by dev_coredumpv
> > 
> > I would have expected a third patch in here, that actually converts
> > existing users. Then in the following release cycle, clean up any new
> > users of the old API that pop up in the meantime and drop the old API.
> > 
> > But I'll defer to the people who would actually be merging your code.
> > Technically it could also work to simply provide the API this cycle,
> > and convert everyone in the next.
> 
> Thank your for your time and reply.
> 
> If this patch set is merged into the linux-next tree, I will send the 
> third patch which targets at linux-next tree and converts existing users 
> at later timer of this release cycle. Because there are new users that 
> may use the old APIs comes into linux-next tree during the remaining time
> of this release cycle.

No, that's not how this works, we can't add patches with new functions
that no one uses.  And it's not how I asked for this api to be migrated
over time properly.  I'll try to respond to your patch with more details
in a week or so when I catch up on patch review...

greg k-h