Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a3361036446058fe386634a9016c6925146a078e.camel@sipsolutions.net>
Subject: Re: [RFC/RFT v5 2/4] mac80211: add periodic monitor for channel
 busy time
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Baligh Gasmi <gasmibal@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
        Toke Hoiland-Jorgensen <toke@redhat.com>,
        Linus Lussing <linus.luessing@c0d3.blue>,
        Kalle Valo <kvalo@kernel.org>
Date:   Thu, 25 Aug 2022 10:58:05 +0200
In-Reply-To: <20220719123525.3448926-3-gasmibal@gmail.com>
References: <20220719123525.3448926-1-gasmibal@gmail.com>
         <20220719123525.3448926-3-gasmibal@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-07-19 at 14:35 +0200, Baligh Gasmi wrote:
> Add a worker scheduled periodicaly to calculate the busy time average of
> the current channel.
>=20
> This will be used in the estimation for expected throughput.
>=20

I really don't think you should/can do this - having a 1-second periodic
timer (for each interface even!) is going to be really bad for power
consumption.

Please find a way to inline the recalculation with statistics updates
and/or queries.

johannes