Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp381027rwe; Thu, 25 Aug 2022 01:58:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR6XfWxH8WpeWdK+Y1P7fizwlkPPwbjRSB2SJ38tBn/pOJOzBd2AJxDSy3YXTwtSRAFiA36f X-Received: by 2002:a17:903:2d0:b0:172:b63b:3a1e with SMTP id s16-20020a17090302d000b00172b63b3a1emr2869173plk.76.1661417915268; Thu, 25 Aug 2022 01:58:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661417915; cv=none; d=google.com; s=arc-20160816; b=Kfb8UIkS2F9VILLaP53OCeoVBijS/1YgcVPrlsVwqPetnUh3UmZE0zoVvRg3Q20ddI lg4jgeXxA9CRzFi+oA7jHWhrbj1E9/L0J/Bl9HQTjPUOU6H196e51wHaIIvOvEouuFmT gy9U60UVlF0vxtFkBZgP/wLkannATPDoKL5pPW0tWC5DNjzQmV7uYC3o+/7+h6gHdiKI S6ZnwJQMSHzhlPgTAYKaLEyZUIN1weFDXyWOTE4jmhySgTcx7V9Zqsus3YDVdxCAIIwR X1O7wnzC3a3H5IL52g7REHQxkMTq1w3JSz2crJmLSeXBASKOIECREXe7pG2KSgnRBn7g /qBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=ixxsyxgLb973PnRaZa2775xCgd4CdHjjz5+/rMoW9tU=; b=jOgJm9WIJByyLlXxKNF8lC+8HzHffWmOBZvafOeuwhgdDLsMa3XLKYYoDikziKctWF gyHzwme3ZXAzRVqc3Q4MhGlAnz3Rg5R0QIUZGqwByzBzHzGGCsuhILDzlXAIdw1vY4IF 41m1V+3+HyHbL/mtyU8cCA18oEe4cMYUgD13tKxnpsDlz2bNC1ALac2XFywscqrtmNYT VGFLN8kfsvZp5fBdoEV5K0pF32f/RvK7Ovhzd1IhpV6t0D2xO55KtU8QpqQC/Rn0gw4M jMpCDUobzkjom69WXMPjIRKVrgV9izKKbWeIkHsde4xayxaRJA131OA4PSN8HNI81V2M m3tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=GgXpL1ag; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s14-20020a170902ea0e00b0016d0d114d30si21090912plg.360.2022.08.25.01.58.27; Thu, 25 Aug 2022 01:58:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=GgXpL1ag; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235132AbiHYI6M (ORCPT + 63 others); Thu, 25 Aug 2022 04:58:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231604AbiHYI6M (ORCPT ); Thu, 25 Aug 2022 04:58:12 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49B0EA7AAA; Thu, 25 Aug 2022 01:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=ixxsyxgLb973PnRaZa2775xCgd4CdHjjz5+/rMoW9tU=; t=1661417891; x=1662627491; b=GgXpL1ags4HlmSkJh5UdDoT9KDH9BCb89wB5FiUB5iw/Owm 7xaOMOZkS4S3DMD4rBg6i4hM84uedQpkq9vat+vIEfD64uy+w2CnkrVYp4xvSx1mvehiOO58E21Ev 9XhhhNq5IlwvYD//MDAtUMLXsni8y4uMRQ4JNu++ENVNeLGSbB9eBW/PEmTfchMjEthT3BKRuRMU1 2iv1mUJUoJdqM2yIc4+7KuYthD/fKA2Rw1v+fCp4CniF+rCMacti2gGYxnzvxHDiC1SKmPDwK/NHy M4NJ55aidbmu5GJDoQdN2xvbEm17hozK6GEaeki0+kl3oeccVXfFvHZkGLkGDT+Q==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1oR8gg-00GzbT-0g; Thu, 25 Aug 2022 10:58:06 +0200 Message-ID: Subject: Re: [RFC/RFT v5 2/4] mac80211: add periodic monitor for channel busy time From: Johannes Berg To: Baligh Gasmi Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Fietkau , Toke Hoiland-Jorgensen , Linus Lussing , Kalle Valo Date: Thu, 25 Aug 2022 10:58:05 +0200 In-Reply-To: <20220719123525.3448926-3-gasmibal@gmail.com> References: <20220719123525.3448926-1-gasmibal@gmail.com> <20220719123525.3448926-3-gasmibal@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2022-07-19 at 14:35 +0200, Baligh Gasmi wrote: > Add a worker scheduled periodicaly to calculate the busy time average of > the current channel. >=20 > This will be used in the estimation for expected throughput. >=20 I really don't think you should/can do this - having a 1-second periodic timer (for each interface even!) is going to be really bad for power consumption. Please find a way to inline the recalculation with statistics updates and/or queries. johannes