Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220719123525.3448926-1-gasmibal@gmail.com> <20220719123525.3448926-3-gasmibal@gmail.com>
 <a3361036446058fe386634a9016c6925146a078e.camel@sipsolutions.net>
In-Reply-To: <a3361036446058fe386634a9016c6925146a078e.camel@sipsolutions.net>
From:   Baligh GASMI <gasmibal@gmail.com>
Date:   Thu, 25 Aug 2022 11:27:48 +0200
Message-ID: <CALxDnQYpA+cpUufxkpyqT=JjZUap-i==bn=r2Z3K2Oayh9QhTQ@mail.gmail.com>
Subject: Re: [RFC/RFT v5 2/4] mac80211: add periodic monitor for channel busy time
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "open list:MAC80211" <linux-wireless@vger.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Felix Fietkau <nbd@nbd.name>,
        Toke Hoiland-Jorgensen <toke@redhat.com>,
        Linus Lussing <linus.luessing@c0d3.blue>,
        Kalle Valo <kvalo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Ok, noted !
I will try to find a way or maybe remove this part, since the busy
time is not trivial to be used in the estimation, as I thought.
Thanks for your reply.


Le jeu. 25 ao=C3=BBt 2022 =C3=A0 10:58, Johannes Berg
<johannes@sipsolutions.net> a =C3=A9crit :
>
> On Tue, 2022-07-19 at 14:35 +0200, Baligh Gasmi wrote:
> > Add a worker scheduled periodicaly to calculate the busy time average o=
f
> > the current channel.
> >
> > This will be used in the estimation for expected throughput.
> >
>
> I really don't think you should/can do this - having a 1-second periodic
> timer (for each interface even!) is going to be really bad for power
> consumption.
>
> Please find a way to inline the recalculation with statistics updates
> and/or queries.
>
> johannes