Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <13b0e503c3b4b87c65da127b5a77547d8e37c9c4.camel@sipsolutions.net>
Subject: Re: [PATCH v2 2/2] mac80211: Support POWERED_ADDR_CHANGE feature
From:   Johannes Berg <johannes@sipsolutions.net>
To:     James Prestwood <prestwoj@gmail.com>,
        linux-wireless@vger.kernel.org
Date:   Fri, 26 Aug 2022 09:50:10 +0200
In-Reply-To: <a424a23753eb922c980d54414a0ad0f015f84e94.camel@gmail.com>
References: <20220811231338.563794-1-prestwoj@gmail.com>
         <20220811231338.563794-3-prestwoj@gmail.com>
         <e898282f0766bdf0bd9cbb92d2a3551ff28cdf6b.camel@sipsolutions.net>
         <1cdf35f95aca2a65d0d738544fb04079125b9581.camel@gmail.com>
         <6fa6b1b62f6a1bc945708cca9e27136f1737386f.camel@sipsolutions.net>
         <a424a23753eb922c980d54414a0ad0f015f84e94.camel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-08-25 at 15:26 -0700, James Prestwood wrote:
> >=20
> > But I guess we could leave setting
> > NL80211_EXT_FEATURE_AUTH_TX_RANDOM_TA
> > to the driver if we think it'd be less risky that way?
>=20
> (I assume you meant this new POWERED_ADDR_CHANGE feature)

Err, yes, copy/pasted that wrong.

> Anyways, is this something all mac80211 drivers _should_ be able to do
> (I thought I remember you indicating this was the case)? I'd hate to
> introduce (expose) a bug for some driver I couldn't test... but also
> the WARN_ON would be very easy to pinpoint what happened.

Yeah, true.

> IMO if mac80211-based drivers should be able to handle this, I think we
> should keep it in mac80211. Any issues that arise would be a driver bug
> that was exposed, and needs to be fixed anyways.
>=20

Agree. And you're setting it early in alloc_hw() so drivers that (think
they) have problems with it can unset it.

johannes