Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a93126420f23f6f019b0b17849e0847f176c4b87.camel@sipsolutions.net>
Subject: Re: [PATCH v3 1/2] mac80211: Add VHT MU-MIMO related flags in
 ieee80211_bss_conf
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Muna Sinada <quic_msinada@quicinc.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Fri, 26 Aug 2022 10:15:44 +0200
In-Reply-To: <1660286767-11853-1-git-send-email-quic_msinada@quicinc.com>
References: <1660286767-11853-1-git-send-email-quic_msinada@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-08-11 at 23:46 -0700, Muna Sinada wrote:
>=20
> + * @vht_su_beamformer: does this BSS support operation as an VHT SU beam=
former
> + * @vht_su_beamformee: does this BSS support operation as an VHT SU beam=
formee
> + * @vht_mu_beamformer: does this BSS support operation as an VHT MU beam=
former
> + * @vht_mu_beamformee: does this BSS support operation as an VHT MU beam=
formee


Should probably say that you meant this only for AP mode?

Though why not fill it also in client mode?

>  	link_conf->beacon_int =3D params->beacon_interval;

You rebased on a multi-link tree ...

> +	if (params->vht_cap) {
> +		sdata->vif.bss_conf.vht_su_beamformer =3D


but still used vif.bss_conf :)

Please respin with MLO support.

johannes