Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a991cbeb70e5f9603f89864278e6acf0f262d870.camel@sipsolutions.net>
Subject: Re: [PATCH] cfg80211: Fix spamming of logs when number of scan
 results is limited
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Larry Finger <Larry.Finger@lwfinger.net>, kvalo@kernel.org
Cc:     linux-wireless@vger.kernel.org,
        Maxim Klimenko Sergievich <klimenkomaximsergievich@gmail.com>
Date:   Fri, 26 Aug 2022 10:22:52 +0200
In-Reply-To: <20220217011226.31579-1-Larry.Finger@lwfinger.net>
References: <20220217011226.31579-1-Larry.Finger@lwfinger.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

Hi,

Sorry I didn't get to this for so long ... Didn't really give it
priority since it's such a strange special case configuration.

On Wed, 2022-02-16 at 19:12 -0600, Larry Finger wrote:
> When the cfg80211 option "bss_entries_limit" is set to 1, routine
> cfg80211_bss_expire_oldest() fails by issuing repeated warnings.

Yeah ... special configuration, not very sensible.

> The problem could also occur in the unlikely event that a scan only finds
> a single SSID.
>=20

That's not true though, it could only happen if there are as many as
bss_entries_limit entries (which defaults to 1000!) that *all* have a
reason to be held in place (e.g. bss->hold, or part of a hidden SSID
BSS).

So to hit this with default settings, you'd have to have 1 network
connected, and 999 real SSIDs for it with other hidden SSIDs or
something like that?

Anyway, I think the right thing to do is to just remove the warning
completely, even if bss_entries_limit=3D=3D1 is probably a config you don't
want to make.

johannes