Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <27395558c865424f9b20d8b976e650926c9322dd.camel@sipsolutions.net>
Subject: Re: [PATCH 1/2] nl80211: Allow transmitting auth frames with random
 TA
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Veerendranath Jakkam <quic_vjakkam@quicinc.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Fri, 26 Aug 2022 10:47:05 +0200
In-Reply-To: <20220708165212.2069149-1-quic_vjakkam@quicinc.com>
References: <20220708165212.2069149-1-quic_vjakkam@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

Hi,

This patch doesn't apply now, sorry I let it linger across a lot of MLO
work.

> - To allow user space to use link address indicated by driver as
>   transmit address for authentication frames triggered by
>   NL80211_CMD_EXTERNAL_AUTH for MLO connection.

Maybe this is already covered by the changes that are actually
responsible for it not applying any more?

You can use the link address now, due to commit 6df2810ac9a9 ("wifi:
cfg80211: Allow MLO TX with link source address").


The PASN privacy thing seems something that would be desirable also for
mac80211, how would you think it would work there? Also for hwsim
testing I guess :)


>  	if (!ether_addr_equal(mgmt->sa, wdev_address(wdev))) {
> +		/* Allow random TA to be used with authentication frames if the
> +		 * driver has indicated support for this. Otherwise, only allow
> +		 * the local address to be used.
> +		 */
> +		if (ieee80211_is_auth(mgmt->frame_control) &&
> +		    wiphy_ext_feature_isset(
> +			   &rdev->wiphy,
> +			   NL80211_EXT_FEATURE_AUTH_TX_RANDOM_TA))
> +			goto out_tx;

Could use else/if instead of goto? Not sure that's better though :)

johannes