Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <117aa7ded81af97c7440a9bfdcdf287de095c44f.camel@sipsolutions.net>
 <20220824191500.6f4e3fb7@kernel.org> <87k06uk65f.fsf@intel.com> <20220826170005.79392041@kernel.org>
In-Reply-To: <20220826170005.79392041@kernel.org>
From:   Dave Taht <dave.taht@gmail.com>
Date:   Fri, 26 Aug 2022 17:13:44 -0700
Message-ID: <CAA93jw5M_ewwhQedshYBwk=SrJSK_61rV-w_H7OXgArrndXXAw@mail.gmail.com>
Subject: Re: taprio vs. wireless/mac80211
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>,
        Avi Stern <avraham.stern@intel.com>,
        linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Aug 26, 2022 at 5:05 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Fri, 26 Aug 2022 15:10:36 -0700 Vinicius Costa Gomes wrote:
> > Jakub Kicinski <kuba@kernel.org> writes:
> >
> > > On Wed, 24 Aug 2022 23:50:18 +0200 Johannes Berg wrote:
> > >> Anyone have recommendations what we should do?
> > >
> > > Likely lack of sleep or intelligence on my side but I could not grok
> > > from the email what the stacking is, and what the goal is.
> > >
> > > Are you putting taprio inside mac80211, or leaving it at the netdev
> > > layer but taking the fq/codel out?
> >
> > My read was that they want to do something with taprio with wireless
> > devices and were hit by the current limitation that taprio only support=
s
> > multiqueue interfaces.
> >
> > The fq/codel part is that, as far as I know, there's already a fq/codel
> > implementation inside mac80211.
> >
> > The stacking seems to be that packets would be scheduled by taprio and
> > then by the scheduler inside mac80211 (fq/codel based?).
>
> Doesn't adding another layer of non-time-aware queuing after taprio
> completely defeat its purpose?  Perhaps I'm revealing my lack of
> understanding too much..
>

A pre wifi-7 mac itself is incapable of doing time aware queuing. It
has to listen before talk, and
wait til the media is free. Even if wifi-7 bears out, it's still dicy.

So even if you only had one taprio'd packet in the sysem and no other
packets, submitting that packet only starts an election to gain the
media.

--=20
FQ World Domination pending: https://blog.cerowrt.org/post/state_of_fq_code=
l/
Dave T=C3=A4ht CEO, TekLibre, LLC