Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp2775187rwe; Sun, 28 Aug 2022 22:49:57 -0700 (PDT) X-Google-Smtp-Source: AA6agR7qRZRJ2l4Q8J+77nGuHWAKaLlLP19KGQseQucUOS50UoPToKMW39kmM/E08Zz06+5+qxhp X-Received: by 2002:a63:581d:0:b0:42b:399:f15a with SMTP id m29-20020a63581d000000b0042b0399f15amr12701184pgb.337.1661752197806; Sun, 28 Aug 2022 22:49:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661752197; cv=none; d=google.com; s=arc-20160816; b=cu/z7cr1YG9jPOUTjwdxruvwIfGfreXkQvm/ZGOXKCX52um54/qv2W6rCKfXIbsMFm 2UjQupER+mR8dNlp6pmhqYssxlP2TzUqTuVi46EJGN5oCYt596/steJ/v9Buy3R7AF+s 5dil3nhHhSJ6irslas2S3ioHMY6XgjUhdL1OIYzUPoWFH1fmgmwnuGxyBAZC9GIrkhZh 89PmgVjs/oYnDLVsmxLdud4ofdiR5DXNjF/7n4xww0yw40kBPED5hud79uowHJp3NBaj EgDV0vJkUeyFTZGhsr8Fmedb7m1xCN1HdsVb48mZ0gjup+UnsmZJg8MKxhLCZaYvwVvO AcTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=d0mmVDo3wWfyZ23/eshXapDFu/x2Fz33VuQuv0G+yrs=; b=TiXHLCkqpXnawigDWRmhhVjovEHhIdnwsa3G7OM/vyNPOTyGE4pjAugkRR6q97uNGG YL/EKvygg5GQ1n5eUS4ndqq0uQfMU33jPhSQ7YVCTsLz5Z1LbPpFt+QI71933EWUzfpr 4PSqf7I4I9UK96EEJ6WDWciC1EDhCxZTY90nGm9VhrkT3vn+M0e3OQAVxV5XS8Ddb794 /lDD3vedIWyVLdsY0h917TnxGRjFBBenyNw8ZE3If301moWKdEhNQXmINK96KOjc05zb GEJ2Z4nEItx7JI7liFx2q1swKcZKslsuUHFKXHR/C43WirS8otKUvsV9aPdNfdJyRly0 TmAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kYqOaQOz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 142-20020a630194000000b0042ab429144bsi8423723pgb.820.2022.08.28.22.49.49; Sun, 28 Aug 2022 22:49:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kYqOaQOz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbiH2Fob (ORCPT + 64 others); Mon, 29 Aug 2022 01:44:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbiH2Fo3 (ORCPT ); Mon, 29 Aug 2022 01:44:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3F546D9D; Sun, 28 Aug 2022 22:44:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E1A036102D; Mon, 29 Aug 2022 05:44:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73919C433C1; Mon, 29 Aug 2022 05:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661751866; bh=eMFwRL1X5gaSXzg8P/8guBiK06GEhxZZRq4kWRJ6818=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kYqOaQOzKmbNNxs1C1nr+5/MxUnIIKIfxJv02W35Vjl1dvEEw9dJ1e+Ypq7MzOwl1 N4dIspThogbIDT7O3rlvkhBkVaP0Tn5et3n2tt8tAa+sVD1SIi0jh1jP9XAkVy6KJw drwWPQg7EMZb0U21PdgpZkoPZywEln/xoyZS/vEGS6FMeOofjwt5QmfsVmvmhvky0X CnW9MkiKBcbPFvtHt+HgwaxzumV3T2aL9sCTBPFQ8UXduk1rviVKuDkAxUMTwC52cn 8TjiGEGplhSTsBxcNdsrkP+q3rTWB8M1ZCaH3b7hMvCSvBTSVRd6fN1Yx/uGQhD/He LuRyyEz06kIFA== From: Kalle Valo To: Stanislaw Gruszka Cc: Sasha Levin , linux-wireless@vger.kernel.org, stable-commits@vger.kernel.org, aleksei.kodanev@bell-sw.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH 6.0] wifi: iwlegacy: 4965: corrected fix for potential off-by-one overflow in il4965_rs_fill_link_cmd() References: <20220813203952.1914688-1-sashal@kernel.org> <20220814075703.GA847900@wp.pl> <20220815073737.GA999388@wp.pl> Date: Mon, 29 Aug 2022 08:44:15 +0300 In-Reply-To: <20220815073737.GA999388@wp.pl> (Stanislaw Gruszka's message of "Mon, 15 Aug 2022 09:37:37 +0200") Message-ID: <871qszhads.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Stanislaw Gruszka writes: > This reverts commit a8eb8e6f7159c7c20c0ddac428bde3d110890aa7 as > it can cause invalid link quality command sent to the firmware > and address the off-by-one issue by fixing condition of while loop. > > Cc: stable@vger.kernel.org > Fixes: a8eb8e6f7159 ("wifi: iwlegacy: 4965: fix potential off-by-one overflow in il4965_rs_fill_link_cmd()") > Signed-off-by: Stanislaw Gruszka Thanks, I'll queue this for v6.0. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches