Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b4b5a72e-4ad2-e249-c71c-c64cf5902a66@gmail.com>
Date:   Mon, 29 Aug 2022 09:27:19 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH 0/4] ath11k: Enable low power mode when WLAN is not active
To:     Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
        "Limonciello, Mario" <mario.limonciello@amd.com>,
        ath11k@lists.infradead.org
Cc:     linux-wireless@vger.kernel.org
References: <20220720134959.15688-1-quic_mpubbise@quicinc.com>
 <ad99d238-dc1a-3233-fc6b-0cd49e428903@amd.com>
 <6daefd60-dcbc-06e1-8091-ea225690edf8@amd.com>
 <ecce8764-1760-4617-49aa-c111305ebd55@quicinc.com>
 <7e00cc36-3a07-92e2-c60e-a3c8939b407e@amd.com>
 <ccdb8f94-0879-2c06-5b48-25c2340d1659@gmail.com>
 <7df6efae-0797-a27a-1372-db7ad16e71d2@quicinc.com>
Content-Language: en-US
From:   Mark Herbert <mark.herbert42@gmail.com>
In-Reply-To: <7df6efae-0797-a27a-1372-db7ad16e71d2@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 8/29/22 08:30, Manikanta Pubbisetty wrote:
> On 8/26/2022 2:31 AM, Mark Herbert wrote:
>>>
>>>> The changes that I have posted will not work on other targets like 
>>>> WCN6855 as is. It requires additional changes and therefore lots of 
>>>> testing.
>>>
>>
>> Will the changes be possible for QCA6390 as well?  Currently this 
>> chip only activates power saving mode when it is connected, but 
>> behaves badly when not associated to any network. So there is a 
>> chance that this kind of solution will help.
>>
>
> Not associated to any network as in Wi-Fi is ON and not connected or 
> Wi-Fi is off?
>
> Manikanta

The way it works now.

I boot my laptop (it is Dell XPS 13 9310). If the network is available 
and QCA6390 associates with it - the CPU package  goes for PC10 state 
for about 70% of time on idle. Even if I disconnect now it will be still 
good.

But if I boot my laptop and never connect (associate to any WiFi ) - the 
CPU will never reach below PC3 with WiFi on. If I disable WiFi - it 
reaches PC10, if enable back - again PC3.


The point is QCA6390 need to be associated to network after boot (or 
hibernation resume) before it activates powersave mode. If this very 
first associatiion is not happening - it will eat battery as mad.

For now I've workarounded it by setting a systemd timer service to check 
if the WiFi is not  associated for f 3 minutes and if it is not - switch 
wifi off.

But it is very strange why this first association is mandatory, because 
if this forst association after boot happened - QCA6390 behaves 
perfectly with WiFi on but not asociated. And continue to work perfectly 
until hardware restart (reboot or hibernate resume) - then again first 
association is needed.  I was thinking that it is happening because the 
ath11k_mac_vif_setup_ps is called only after the association so I've 
tested the patch to call it earlier, and still no luck.