Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 11:53:24 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Ilan Peer <ilan.peer@intel.com>, linux-wireless@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wifi: mac80211: Unlock on error path in
 ieee80211_key_link()
Message-ID: <20220829085324.GN2030@kadam>
References: <Ywx7xR590F6lUA4l@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ywx7xR590F6lUA4l@kili>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+1gBs6XS+o06edyyCzh5M/IPOkgfoONwmOIebjjDu+rWX1h6LbNSS7mZy+Zh?=
 =?us-ascii?Q?hWs0HpylAPyP5mGAhUjQGWd3myq8iMgv6fSJaF4Yk4yO2EPloU7Z0UYyr49I?=
 =?us-ascii?Q?n4TE76cR/aidGO31Tu0ehlV+8gH+dY5kHkoLAS+GXf714lxPjuEk4KPUK18g?=
 =?us-ascii?Q?fID6MRmOmlxqZaXlxOgwhp1R5qqG2Kx2BTlZvPuUy3NhbCuTMA8eD1Ot0B1A?=
 =?us-ascii?Q?CBk357xfEPik3YCJ4cVZFVo+VHy61BcQpjL6m4FT/iQO6aC3HSMOElzkU+KF?=
 =?us-ascii?Q?zbXIb1gRuqho1FLOjgYSiH4XSNi/KkjytR/0UC9kPY/co4rV/PWcbU3k8v0U?=
 =?us-ascii?Q?Rl3oCvggF5BXnIUBaaQ+spAISE6sIACqHjbuxcCN/ImcKdX4o3utSp+m+8kt?=
 =?us-ascii?Q?oSnHX8esQRNa1El8HwAFLdw1VMfoDGXR1DBYg3MZX7Mj3zVKnVT3exPiOjNQ?=
 =?us-ascii?Q?emJVVds/SE7+4bkSY5c33BvT/YD93X4maTZVrlqPb0nYzyv9vKlM8fb2JkzJ?=
 =?us-ascii?Q?I0xVRmrT5dln0cG1w9DhEu7C2SNGTuSTq/p2JU2l54tqPqt/mhLFJpWYz1Ju?=
 =?us-ascii?Q?dTxRng+NAAzax/G/ixeVy5OAuPbkxJEOphXNYtRmU4BtzHjallzANGt4tArg?=
 =?us-ascii?Q?GvplRm5Orj70ja3j2TU/jXF/KGSEs84X5KC+1fj4YOkoB7/oIaANpHGhyGae?=
 =?us-ascii?Q?E8HYHM9z8w2rD6GdTo3m7WgJeVq57gE7n7BjPxFZnFjK/qMBhCSfKJ+Fi1Vv?=
 =?us-ascii?Q?eC9vm26aChpsIwi1cyO0+UXezRdsHJAzXqiTV015rwXjrkvEX/kLpkoY0C+x?=
 =?us-ascii?Q?hFMO2LJ2gSNlPopQJra+Jg09Kxq6nwclsLGx2sojzGw1CzSEXVoAq099AvSA?=
 =?us-ascii?Q?+Zp5q+c+/a+weto8eI7d3Os+qswEzRHtM7wK0WKoYsdrDUk3AVRrGRSR2VIm?=
 =?us-ascii?Q?wQAUxNW14Fok1SwTTiwFQawJG60cc7dXRPxwBQIIsF3BKsUKS4ZRc/BHPyhl?=
 =?us-ascii?Q?39WasNc+8geLgX5J/3w4FQwhhPyPvJSLBkwMb9icVylV99POxkiotfd8IMkS?=
 =?us-ascii?Q?2GGiWEDQTeMBaaT8LVg4N3ubHmm0yWchDCLa8EFaSHiocZ5h8sVyezHlnxFj?=
 =?us-ascii?Q?TZ9kcE15cb8MPCCSyp65YVy5EVbR2qw/X0AlQAhygPwL3ducd+Y+D//VEvjm?=
 =?us-ascii?Q?setcWHSwQZ5Q0f8djshg+xBxmGp/8Vzqm1pNFWaRdmEM2lz+oGPX5862kRYZ?=
 =?us-ascii?Q?0TjZdukdmvA2NfhiONH62fjCVcfxzso+L2uVRbz12NcPPDEFA5Q91OGcDxbH?=
 =?us-ascii?Q?ubyMaH36uCk2F2fkiDNnB2nUNn3jef+6rWzCohNys3rNPHiRciJF/y/F2mOX?=
 =?us-ascii?Q?6/hR9fkzo5z6HIeQcXaEFGrqIBhqQe/CWXuIbqRNu99QlmJ6d9ZwirwWz9+p?=
 =?us-ascii?Q?P4cvkbEB9sBMMNwsAYfenqc7+mgSBFGAiv+BJ2sz5hFkcio/xif29hX5lkeB?=
 =?us-ascii?Q?4FlRj7i7DIKWJzHMC3RiNmscXu7/euXC6JKC7mIkXJhkrm0iTkYCapQ8Ttel?=
 =?us-ascii?Q?YiwwRa9izpNGLYtHTP4CyIQ6yyNOjAgfPxlIoFpzqYv919dTtpPmxbJBjhXl?=
 =?us-ascii?Q?Gw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a199bfc-26f3-430c-32c1-08da899bf4be
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 08:53:34.7575
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uzfp2ckZx9Wb8PKK29JUyN0+3uu4AnAqnpCPgmScQbpkrzM7XFSZWDxWO7bfGXsXOwbwHdyt1EsbitnO8N9B20eIEXWSGq3lxqgjH6E4XUg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB5946
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-29_04,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 mlxlogscore=821 phishscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208290044
X-Proofpoint-ORIG-GUID: hJm3IbTHngEQXUzPqHSzkQ6uzdOrMxWh
X-Proofpoint-GUID: hJm3IbTHngEQXUzPqHSzkQ6uzdOrMxWh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, Aug 29, 2022 at 11:41:41AM +0300, Dan Carpenter wrote:
> Unlock before returning on this error path.
> 

Never mind.  I see that Sun Ke already sent this.  I need to make
checking lore a standard part of my QC process instead of only for
uninitialized variable bugs...

regards,
dan carpenter