Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ce01865907335ee597d204eb3cc8caea6b6326c2.camel@sipsolutions.net>
Subject: Re: [PATCH 1/1] cfg80211: Update Transition Disable policy during
 port authorization
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Jeff Johnson <quic_jjohnson@quicinc.com>,
        Vinayak Yadawad <vinayak.yadawad@broadcom.com>
Cc:     linux-wireless@vger.kernel.org, jithu.jance@broadcom.com
Date:   Mon, 29 Aug 2022 11:52:45 +0200
In-Reply-To: <c177e3cc-ae69-b8c8-bb72-be85b2262149@quicinc.com>
References: <e8fb69386675e5d128db141dabb9e6dad75eb841.1661516424.git.vinayak.yadawad@broadcom.com>
         <c177e3cc-ae69-b8c8-bb72-be85b2262149@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-08-26 at 08:48 -0700, Jeff Johnson wrote:
>=20
> > @@ -3268,6 +3270,7 @@ enum nl80211_attrs {
> >  =20
> >   	NL80211_ATTR_TX_HW_TIMESTAMP,
> >   	NL80211_ATTR_RX_HW_TIMESTAMP,
> > +	NL80211_ATTR_TD_BITMAP,
> >  =20
> >   	/* add attributes here, update the policy in nl80211.c */
>=20
> Johannes, do you want the policy updated even thought this is=20
> driver->userspace and hence the policy is never applied to it?

Yeah in a sense, it doesn't really matter... I think not updating is
fine, then it will likely even be rejected, at least in any new
commands.

> >   		struct {
> >   			u8 bssid[ETH_ALEN];
> > +			s16 td_bitmap;
>=20
> I know you are using -1 as an indication that the bitmap is not used,=20
> but using signed with a bitmap seems strange since bitops can be=20
> affected by sign extension. Just something that set off my Spider-Sense.

Yeah true ... maybe a separate validity bool would've been better?
dunno.

johannes