Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Ping-Ke Shih <pkshih@realtek.com>, tony0620emma@gmail.com,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: rtw88: fix uninitialized use of primary channel index
In-Reply-To: <YwZ+RsHL+n02gHZx@dev-arch.thelio-3990X> (Nathan Chancellor's
        message of "Wed, 24 Aug 2022 12:38:46 -0700")
References: <20220815062004.22920-1-pkshih@realtek.com>
        <YwZ+RsHL+n02gHZx@dev-arch.thelio-3990X>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Date:   Mon, 29 Aug 2022 18:35:39 +0300
Message-ID: <87o7w3f4fo.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Nathan Chancellor <nathan@kernel.org> writes:

> On Mon, Aug 15, 2022 at 02:20:04PM +0800, Ping-Ke Shih wrote:
>
>> clang reports uninitialized use:
>> 
>> >> drivers/net/wireless/realtek/rtw88/main.c:731:2: warning: variable
>>    'primary_channel_idx' is used uninitialized whenever switch default is
>>    taken [-Wsometimes-uninitialized]
>>            default:
>>            ^~~~~~~
>>    drivers/net/wireless/realtek/rtw88/main.c:754:39: note: uninitialized
>>    use occurs here
>>            hal->current_primary_channel_index = primary_channel_idx;
>>                                                 ^~~~~~~~~~~~~~~~~~~
>>    drivers/net/wireless/realtek/rtw88/main.c:687:24: note: initialize the
>>    variable 'primary_channel_idx' to silence this warning
>>            u8 primary_channel_idx;
>>                                  ^
>>                                   = '\0'
>> 
>> This situation could not happen, because possible channel bandwidth
>> 20/40/80MHz are enumerated.
>> 
>> Fixes: 341dd1f7de4c ("wifi: rtw88: add the update channel flow to support setting by parameters")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> Can we get this into -next soon? This warning is breaking our builds due
> to CONFIG_WERROR.

Johannes applied it:

https://git.kernel.org/netdev/net-next/c/4ffb4d25ef12

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches