Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Dan Carpenter <dan.carpenter@oracle.com>,
        linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wfx: prevent underflow in wfx_send_pds()
Date:   Mon, 29 Aug 2022 19:12:40 +0200
Message-ID: <37769865.10thIPus4b@pc-42>
Organization: Silicon Labs
In-Reply-To: <87a67ndokl.fsf@kernel.org>
References: <Yv8eX7Xv2ubUOvW7@kili> <2729343.a3EqFhE7eK@pc-42> <87a67ndokl.fsf@kernel.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?tyOIsURdqWzRAwmYsbVBJ/n/hiL7Yfj/HTm+8heDN1+VD9ioyhziNxgBKL?=
 =?iso-8859-1?Q?QM0FwCSNWrNO+WKuhTZYQFC2IOQnXhqMvwWIlgnqG+RJEnlIVLFSKQD9p5?=
 =?iso-8859-1?Q?i1KDgfJj1FXAHNPvZoDL+3mPZFU5YJ2AOw++GC0P/vIUvvEonSkpWaL/uM?=
 =?iso-8859-1?Q?amJbPbx8LWct2WqPvgbbkTKRXPyq/QT6xLmGbSl9e1Kpyd9Qu5lABf9o5k?=
 =?iso-8859-1?Q?ZPftbPXoDomH0LfCMC/QyO7mdnxYJ1/W8ZNrzvRFElHZkRmkVcbW7m/H2l?=
 =?iso-8859-1?Q?fQp3Sx034YL3h9TqhEsf8g4V8+Vw7F7oDMAARt+IYaX+2vsKIuHUL121Hy?=
 =?iso-8859-1?Q?rK/3fwE6+6vvk/FFGPebqlyKg29ierRhamtl+MCk9Zbom9b2PK1vzUdjzn?=
 =?iso-8859-1?Q?pagS66fSu/p/Ocb4sqI9XCMUojkMHNGfl/YwG7irul80CT5LXxn8sA5bID?=
 =?iso-8859-1?Q?YazArDC0PEbc8hU4yIGkSBciLvy9JGQv3fRDV/6g0J1lV4TgW6hkFzoQN0?=
 =?iso-8859-1?Q?UGW2J2iFl+cr1+OYs2iyLGbuwGVitwmkhRipVrwhYXRpiQPAlbcdEzlIVO?=
 =?iso-8859-1?Q?hd0UGzpv8WefJ4DY5VnHgk2pgzdlrDvE9A4VnKJSATS7DNU6WTTvWteXGI?=
 =?iso-8859-1?Q?ieto3IMcCqgQ5m2HmgXFmuRwj5ZbWClbWriKCr4nwkjpIQVy3B2EaDDHW4?=
 =?iso-8859-1?Q?wbMSkB/b1//UmC3jEuUOU5U1DGy9d1DTPEpZF4mYpJ1senHa+mQkBin/vA?=
 =?iso-8859-1?Q?KZ/K9ZxIW9ujPCaN6XTMe1JIporARmShrZbvOZN/eBHeup8cSEtvqZZYGO?=
 =?iso-8859-1?Q?q1bPARD0k+XE3esQXYwEk8/f1Nv4i2oNEqdgsq0C+514DjS6ehvol6TQAR?=
 =?iso-8859-1?Q?IuHskkuIjode70ciNEMBh+AIvyQu1S5ZpP8YLHnNo9oEmEnR69g7MJO7iT?=
 =?iso-8859-1?Q?x4ovn3Oct3Dipl0juxvVauy0m9zPQK6cPBGXqb3EP/IznBAx7InpxLqkOY?=
 =?iso-8859-1?Q?bkLH7tWBPBazTinjVEO88Q57+b+ev3TiKT4hqFAy9NYSlyRVYtPdy2phnB?=
 =?iso-8859-1?Q?uCNHVXcAjttkUwdcTWPFfFncW15fbWTo8/2O1UMTyNSrtU/OYuIiarFh25?=
 =?iso-8859-1?Q?fPdVFEn4WWvP/y35Pq7DZTfUHs/cZCZ5pckBpd92B/6+TTO9xRciGqq0qk?=
 =?iso-8859-1?Q?zoBJvIyaZakbTnQUTfY1Pe0ufeH8jBIgIUgQmIWSi1z3MbiKvfVJrPDSos?=
 =?iso-8859-1?Q?/RBlrldAeQT4fn9XhAecx4vYWZSYb7wVxQu+niOLWxtum3r447+xw4mBUe?=
 =?iso-8859-1?Q?RVQhEFEIjg6FAKMCx81kAzeI2FnpXCPZmMCWVACsIhNDRtibwwFK05lyP7?=
 =?iso-8859-1?Q?SiHfgUEHEn4EgW1O3+3pHNEgekv2CAw10SelpBuYEBc9GqPR58Elpfm2ka?=
 =?iso-8859-1?Q?eg3Qwxk2uWTaznrt7J5B5o8Z7m/kNFFZgtx6fepwy4DPuKbDLHG6Z8RdkU?=
 =?iso-8859-1?Q?HFoB9FGoFVRouSiDcQMMnGnM9Rr9qOpIioS9hWdCMefW3yMSD/+JbSBoOk?=
 =?iso-8859-1?Q?2NorZzoheRAAdEutQM3pKbOuOHibRdckyx3JtkxmrPaA4VgrwMAeMijCrx?=
 =?iso-8859-1?Q?kFSkVOCly22CU/+l9WJANyKMvD+Oc/s4TE4Ov2i+/UoNTDVOTl0t2laXi/?=
 =?iso-8859-1?Q?H9ryU+P2elT3DCI7FAD4dwCf+SVZAFUkbQGLhX0N?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04d2add4-83ae-4b97-997f-08da89e1affc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB6038.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 17:12:44.1903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rEuDtsYxqahdZrRd5mLDKpxjb6AOFPzQQ2/OgI5Ahtdh+zQXQkd3U6u4/kqDtO3oiRJ3VO14OB9wpjpXEhR9yA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6195
X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Monday 29 August 2022 18:03:38 CEST Kalle Valo wrote:
> J=E9r=F4me Pouiller <jerome.pouiller@silabs.com> writes:
>=20
> > On Friday 19 August 2022 07:23:43 CEST Dan Carpenter wrote:
> >> This does a "chunk_len - 4" subtraction later when it calls:
> >>
> >>         ret =3D wfx_hif_configuration(wdev, buf + 4, chunk_len - 4);
> >>
> >> so check for "chunk_len" is less than 4.
> >
> > This patch also ensures that buf[4] won't overflow during:
> >
> >     if (buf[4] !=3D '{' || buf[chunk_len - 1] !=3D '}')
> >       dev_warn(wdev->dev, "PDS:%d: unexpected content\n", chunk_num);
> >
> >> Fixes: dcbecb497908 ("staging: wfx: allow new PDS format")
> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > Reviewed-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
>=20
> BTW J=E9r=F4me, as you are the driver maintainer you can use Acked-by.

Reviewed-by does not imply Acked-by?

--=20
J=E9r=F4me Pouiller