Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <72139841-f5ba-6fb8-8268-f59cee0a2bc2@gmail.com>
Date:   Tue, 30 Aug 2022 13:35:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2 linux-next] wifi: brcmfmac: remove redundant err
 variable
Content-Language: en-US
To:     cgel.zte@gmail.com, franky.lin@broadcom.com,
        hante.meuleman@broadcom.com, kvalo@kernel.org, davem@davemloft.net,
        edumazet@google.com
Cc:     kuba@kernel.org, pabeni@redhat.com, johannes.berg@intel.com,
        alsi@bang-olufsen.dk, a.fatoum@pengutronix.de,
        loic.poulain@linaro.org, quic_vjakkam@quicinc.com,
        prestwoj@gmail.com, colin.i.king@gmail.com, hdegoede@redhat.com,
        smoch@web.de, cui.jinpeng2@zte.com.cn,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
References: <20220830105016.287337-1-cui.jinpeng2@zte.com.cn>
From:   Arend Van Spriel <aspriel@gmail.com>
In-Reply-To: <20220830105016.287337-1-cui.jinpeng2@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/30/2022 12:50 PM, cgel.zte@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> 
> Return value from brcmf_fil_iovar_data_set() and
> brcmf_config_ap_mgmt_ie() directly instead of
> taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> ---
>   .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c    | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 7c72ea26a7d7..8a8c5a3bb2fb 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
[...]

> @@ -3997,10 +3996,8 @@ brcmf_update_pmklist(struct brcmf_cfg80211_info *cfg, struct brcmf_if *ifp)
>   	for (i = 0; i < npmk; i++)
>   		brcmf_dbg(CONN, "PMK[%d]: %pM\n", i, &pmk_list->pmk[i].bssid);
>   
> -	err = brcmf_fil_iovar_data_set(ifp, "pmkid_info", pmk_list,
> +	return brcmf_fil_iovar_data_set(ifp, "pmkid_info", pmk_list,
>   				       sizeof(*pmk_list));

You should align the next line on the column after the opening brace. 
Using the checkpatch script should report this.

> -
> -	return err;
>   }
>   
>   static s32