Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4421619rwe; Tue, 30 Aug 2022 09:47:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR705FqQI8bXpZi2TwATDA/9D0M6pjgVjXgCyKndap5eDSjaNwKcv8wEp+kP0BB/8HwrsJvW X-Received: by 2002:a17:906:4fc4:b0:73d:d4e9:2d6e with SMTP id i4-20020a1709064fc400b0073dd4e92d6emr16952150ejw.165.1661878020398; Tue, 30 Aug 2022 09:47:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661878020; cv=none; d=google.com; s=arc-20160816; b=C1cHY5RYqY3EHJokeA14CHSbdQlQBzOimqW04LTQQ0CngcgXz5eby3ViI/pq2NMvvR CEysHXY72Zm/4Xcggdi0DDI3zv2R8CiA8psxGJ5x33ghqUKuTPFd1Vt+JVbZGw9fQ6Bq KA5YvRSwKsUQZTywR0fYQcWwAfKMd3rJJT8bvU2FNgfBWiOCOVE6g4fNVITh8JnDtYqQ U6UM2Oy4gQr8r7GyftzaEPT4ek06hgu54h0ASgqnH4H+QtruBqTENbNDmHm86TJrJrJj 8wxU3tve1X906oAJP+pbbBjsTWq0l7Cvot8o4+lMFyUsrmhVsnxa7RQP4TJ7ossa3wK6 jYBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=WykV7+JA3FQi6Oe03VCo1d4iZI4/8BWb5waRqQ6tXEg=; b=VMW/GUMN++wrf/fSmCpD38lKF5Ucr3b1KbhUfs1iOwGg5taYkv+B0IFASlE9uCdV5V KI1qDCQyLF6bPfTIPLm7wSSshV3WYmk+FGH/fL4XfcbqKhRs1EfIh+7L7CV/gjNQdmgT Mkxrdk0KZjBJ6HbzAHaHdiZU3VXDm+QceAqftWo6Tg/RqtiydRm92zqi6jxyGLrf/TfV gu8H/u1acKNPToDJhUY7MY1OspZ/D7BQKuAQmYzct6WrR8+zkxyZYDiKvBmF1pttWqQq s/2nNEula41YiYTRQ4hENtW1GkuF0s6Mhw6/ZnwE0ws+gzcvQsXg5nNroS+sFLNnW/fb sVvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Qh5O2tx3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xe4-20020a170907318400b0074133918ba1si9528745ejb.331.2022.08.30.09.46.39; Tue, 30 Aug 2022 09:47:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Qh5O2tx3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230112AbiH3Qgy (ORCPT + 64 others); Tue, 30 Aug 2022 12:36:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230122AbiH3Qgs (ORCPT ); Tue, 30 Aug 2022 12:36:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1FC1B7754 for ; Tue, 30 Aug 2022 09:36:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3692B81CD8 for ; Tue, 30 Aug 2022 16:36:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1450CC433C1; Tue, 30 Aug 2022 16:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661877403; bh=TFRHNAB562YkyJdjR5mxnm2w0A/qdLViHJHohLlVuEQ=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Qh5O2tx3+kORPzU33VnIDoqD/IcodC3MhVNkWx+fqQMfGX9FXmrbZzuJ8MeANKQ6h xVZ7f6KM7M7hKypc8yPM6LUVEf3Sw3mzFUJEKZgeKKOBkjxnRurO3IVXqE5dAPsk50 pjvFUROvQ0OJuTDXujGMdiXTtm1uglW3eARgaEpmV0l2P6cgEeG74wVYGSws3qrEN3 h1EjovkrPl9Nc2fvmcM7WNo5/EuUE9m+gNiwYv8qLO5xRwbqlZZ7Mene49E8wjKUZy YCWoks0F46TlIBcHbl+5ntie5VwfW9vCQho1b+0AX/Lh8SOyvUgtPM2LJGrBEAg+Fd 9wywEvb67vnUA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] wifi: wilc1000: fix DMA on stack objects From: Kalle Valo In-Reply-To: <20220809075749.62752-1-ajay.kathat@microchip.com> References: <20220809075749.62752-1-ajay.kathat@microchip.com> To: Cc: , , , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166187739680.28049.7809271821015045293.kvalo@kernel.org> Date: Tue, 30 Aug 2022 16:36:41 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org wrote: > Sometimes 'wilc_sdio_cmd53' is called with addresses pointing to an > object on the stack. Use dynamically allocated memory for cmd53 instead > of stack address which is not DMA'able. > > Fixes: 5625f965d764 ("wilc1000: move wilc driver out of staging") > Reported-by: Michael Walle > Suggested-by: Michael Walle > Signed-off-by: Ajay Singh > Reviewed-by: Michael Walle > Tested-by: Michael Walle Patch applied to wireless.git, thanks. 40b717bfcefa wifi: wilc1000: fix DMA on stack objects -- https://patchwork.kernel.org/project/linux-wireless/patch/20220809075749.62752-1-ajay.kathat@microchip.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches