Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3b169ca3-2962-339f-c8cb-c48ac41c9aa5@linaro.org>
Date:   Tue, 30 Aug 2022 20:25:56 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH v2 1/2] dt: bindings: net: add bindings to add WoW support
 for WCN6750
Content-Language: en-US
To:     Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
        ath11k@lists.infradead.org
Cc:     linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
        robh@kernel.org
References: <20220829124323.26874-1-quic_mpubbise@quicinc.com>
 <20220829124323.26874-2-quic_mpubbise@quicinc.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220829124323.26874-2-quic_mpubbise@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 29/08/2022 15:43, Manikanta Pubbisetty wrote:
> Add required bindings to support WoW (Wake on Wireless) for
> WCN6750 which is based on ath11k driver.
> 
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>

Use scripts/get_maintainers.pl to CC all maintainers and relevant
mailing lists.

> ---
>  .../bindings/net/wireless/qcom,ath11k.yaml      | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> index a677b056f112..307a5b9d1588 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> @@ -66,6 +66,14 @@ properties:
>      required:
>        - iommus
>  
> +  qcom,smem-states:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description: State bits used in WCN6750 to signal the firmware
> +                 to exit from WoW.

You need to describe the item (s).

> +
> +  qcom,smem-state-names:
> +    description: The names of the state bits used for SMP2P output

You need to describe the item (s).

> +
>  required:
>    - compatible
>    - reg
> @@ -410,6 +418,13 @@ examples:
>          };
>      };
>  
> +    smp2p-wpss {
> +        wlan_smp2p_out: wlan_smp2p_out {

No underscores in node names. This example is incomplete and I am not
sure what is the benefit of adding provider example to the consumer
binding... Just skip it.

Best regards,
Best regards,
Krzysztof