Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e69b7d24-a9a1-a022-e59b-f400532d0da0@quicinc.com>
Date:   Thu, 1 Sep 2022 16:03:16 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 1/2] nl80211: Allow transmitting auth frames with random
 TA
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>
CC:     <linux-wireless@vger.kernel.org>
References: <20220708165212.2069149-1-quic_vjakkam@quicinc.com>
 <27395558c865424f9b20d8b976e650926c9322dd.camel@sipsolutions.net>
From:   Veerendranath Jakkam <quic_vjakkam@quicinc.com>
In-Reply-To: <27395558c865424f9b20d8b976e650926c9322dd.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/26/2022 2:17 PM, Johannes Berg wrote:
>
>> - To allow user space to use link address indicated by driver as
>>    transmit address for authentication frames triggered by
>>    NL80211_CMD_EXTERNAL_AUTH for MLO connection.
> Maybe this is already covered by the changes that are actually
> responsible for it not applying any more?
>
> You can use the link address now, due to commit 6df2810ac9a9 ("wifi:
> cfg80211: Allow MLO TX with link source address").


The pointed commit changes not helpful in external authentication case 
due to WDEV won't have link addresses information when external 
authentication triggered. The link addresses in WDEV gets updated only 
after association during connect response processing.


>
> The PASN privacy thing seems something that would be desirable also for
> mac80211, how would you think it would work there? Also for hwsim
> testing I guess :)
>

Need to check what additional changes needed in mac80211 to support this 
feature. I will check and post required mac80211 changes in v2 series.

>>   	if (!ether_addr_equal(mgmt->sa, wdev_address(wdev))) {
>> +		/* Allow random TA to be used with authentication frames if the
>> +		 * driver has indicated support for this. Otherwise, only allow
>> +		 * the local address to be used.
>> +		 */
>> +		if (ieee80211_is_auth(mgmt->frame_control) &&
>> +		    wiphy_ext_feature_isset(
>> +			   &rdev->wiphy,
>> +			   NL80211_EXT_FEATURE_AUTH_TX_RANDOM_TA))
>> +			goto out_tx;
> Could use else/if instead of goto? Not sure that's better though :)


sure, will do required changes in v2 series

- veeru