Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1675516rwe; Fri, 2 Sep 2022 01:39:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR44W9rhgc7L+Z56lC1csOHcuyGAYvl+kl7efTgItYrdfQnOVgBXT+LuDYPnxipV4/V5Cyhy X-Received: by 2002:a05:6402:190e:b0:43e:1588:4c32 with SMTP id e14-20020a056402190e00b0043e15884c32mr31874322edz.76.1662107945331; Fri, 02 Sep 2022 01:39:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662107945; cv=none; d=google.com; s=arc-20160816; b=qcpkR3kD42E1J2N1qzYTlrE9p5VnxZIAFRBkww0Q3O8WFRGzPTipxgumJsIaL67IJ6 IiOfKjWZ80LeEXBg8L4TNrnbnihf+GOPbaIJNGmYodsN1KBB/vWhMVCEPMTA+iKRNZVb gbi2XCCu+5oS5gaLAqUZ90TMn4E74GZHPhgagq++slb4TsPQ656TvGFMoaNqfABdfeAB dmS3gXB3yWbzwm8Q5ZtR0i6gaOJjjRg+CH+/XKGiU1mlZJoT5PqhoM3G9m3MdsDBWsUp MwllXgjFmFn+Ftyzdulkxi1+EcGDmori4yCtUh9HAg88c7lfObFyMZbXm3vjl1FZNuhn Afqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=fbqcTc5Te7J8o+gptQcuMJFe6P8+uvPr3tcLoHzBOrY=; b=BF0dYrZQZGikwwzwoW3K7ol+vX0QeJEl13nYHcjn2P4a6kBkXcknWetIjDT/mokj0v E6r1wv/ERLRDF+ijlyw6yyf1qsH+QBr1dw6oWWrx7wnwoyD2O+YeEWMWDqOJFFO8Tiz8 euHIJ/NfTSPQZr8PPNW4OIGVWhgDyckT+4dZomoNn7BNdrX0ESToceVq+wS52h4m5cQd D+2j1syr/0xR39KkZhguhwqxe4LRlpa9mAGml50fJOqdxJ8ValpPuJ/NNrjLFKFuDftJ BGWy+fA6TGNNjceJEe0T19RX3g/pFZ6QnlQLQTHeqx+rPFoVvP7x/dsr3HUgjBunaupn sdHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FRT/WAt3"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go14-20020a1709070d8e00b0073dced72063si1846109ejc.570.2022.09.02.01.38.49; Fri, 02 Sep 2022 01:39:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FRT/WAt3"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230317AbiIBIh3 (ORCPT + 64 others); Fri, 2 Sep 2022 04:37:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235889AbiIBIhP (ORCPT ); Fri, 2 Sep 2022 04:37:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AEF6C2FAE for ; Fri, 2 Sep 2022 01:36:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DCEBCB82A07 for ; Fri, 2 Sep 2022 08:36:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73E5DC433D6; Fri, 2 Sep 2022 08:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662107778; bh=vrXhMaFtESzSKJTp35JvUWUAOSbyvPKO30+wLmS9mIk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=FRT/WAt3qS+Hw8lWZ+MqFxnjfbxnMXmY/AAcaUcDYkaSHvVF7Wk2pJ8ipfnjZjhVh tr0c4Q8XTcFuYp9EIVESVZTABYc67YbUaTr3ajW7W79+9qLivLlttrg9K26dneyCBc ouL9fwO8wNC5+fRf9p9Z+sElNEhtDVkjQTIRgGB4O2p466KDd9XhGOH5eN51ATd8VP GWnsukBwVcwalo0Q3dsJ5s7l1Jvl1kujGP+BISXhqbxCnljoELbJrUwyCUuUT+0Zuy pAtNkXgo0dn+nhtCfbbEhxfHeviNv1/f5Z4oNga1kO2DI8dFtrjUjxjMVnLmko05e2 qsP0lj7sdlaVQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2 1/5] wifi: rtw89: add retry to change power_mode state From: Kalle Valo In-Reply-To: <20220819064811.37700-2-pkshih@realtek.com> References: <20220819064811.37700-2-pkshih@realtek.com> To: Ping-Ke Shih Cc: , , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166210777544.24345.4788231399815899200.kvalo@kernel.org> Date: Fri, 2 Sep 2022 08:36:17 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih wrote: > From: Chin-Yen Lee > > When starting to send heavy traffic in low power mode, > driver will call multiple tx wake notify to wake firmware > within a short time. In this situation, firmware may miss > power mode change request from driver and leads to status > error. So we change driver to call power_mode_change at most > three times to make sure firmware could get the request. > > Signed-off-by: Chin-Yen Lee > Signed-off-by: Ping-Ke Shih 5 patches applied to wireless-next.git, thanks. 48c0e34755a1 wifi: rtw89: add retry to change power_mode state 704052f55ffe wifi: rtw89: 8852c: set TBTT shift configuration 8f308ae3342c wifi: rtw89: pci: fix PCI PHY auto adaption by using software restore 843059d8193c wifi: rtw89: pci: enable CLK_REQ, ASPM, L1 and L1ss for 8852c 9e3d242fd3b4 wifi: rtw89: pci: correct suspend/resume setting for variant chips -- https://patchwork.kernel.org/project/linux-wireless/patch/20220819064811.37700-2-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches