Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1680777rwe; Fri, 2 Sep 2022 01:46:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR5HGQVSER4sr0ZtDmVb2kAGFltdKGQnRLRBjaxqOTvrrJEDJ+rnvB8QzUoSZDTpGK0ETmTv X-Received: by 2002:a17:906:4fc4:b0:73d:d4e9:2d6e with SMTP id i4-20020a1709064fc400b0073dd4e92d6emr26153471ejw.165.1662108415888; Fri, 02 Sep 2022 01:46:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662108415; cv=none; d=google.com; s=arc-20160816; b=Pk13qiqLedh43kjEYbkpVRDIAlaaU6XyhAC/sG2NqbDBECGHyiBAxBH87MxLnzJR5U yRbXuvKErhIibN0iPCY31Md6q94FF6LISCfY8Wl8y26tCxddi3mwK+6ISKjMI1DW/7lX BmcGQa48io4WcP0UHY3rb+NOekImrW+vDYym7FNBEYahHsmsrVKhh3bcqvHH7so5cXR5 7BrvcF9PxC0Ghm1vpYKaQaDfjsLaotGDR/U8xWOnofb8WSrUgqpB0+7RRSszgq2WKbkN sjmK44mvD1Cf9ZNK/wIEq5+HAUr8AAjLI/uC0QxROVFvkfPV9bFfIoNurjBioRdd8TSp EVHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=tIsgGPPtjocTkCuR0f6nUd5wp/mJFFHj0e0CujbYqmg=; b=CfxEu+ZYiaTGGlKA8dpBpFOoo/AEwIBzogQio8VEvKSrOZNTym3sUwUn36GY6lAFhQ 8fNUTkzruQ6XlfW2ZuiceT0XUXlSlg8HfIkzhaodIj5C+GaEf6n5lqHero1bOVqHGuRv VQEO6AtDc6MtgB887V02MKFmicgVXgKOcY3f2im4JZEkH7HwIU0bRZtKg14W2WRdI1pE 5yPMUDwB8KNSvxc+bAn+1cdrikSbx0rEGPl+t9BRom7XrQRYU/vMS2SUZQyuyjUwYcQg A5JzPLIWNQfsMU4DMNdKrs9mlT7DOluz+QvU2bs2OawrPwV/FmdT+rJUjZrEcVifYrem 9ebQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="OgEUqXs/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go36-20020a1709070da400b007317732083csi1801728ejc.274.2022.09.02.01.46.38; Fri, 02 Sep 2022 01:46:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="OgEUqXs/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236028AbiIBIpi (ORCPT + 64 others); Fri, 2 Sep 2022 04:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236011AbiIBIo5 (ORCPT ); Fri, 2 Sep 2022 04:44:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D460C6FEE; Fri, 2 Sep 2022 01:44:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C963B82A07; Fri, 2 Sep 2022 08:44:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 820D0C433D7; Fri, 2 Sep 2022 08:44:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662108244; bh=6hdLK6PCwUeLXTcuhG+ltsWwMLR/FDMBIukZ9/RvQ2I=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=OgEUqXs/2QIL2tPFTWi8oBN6B75vtUJmNjvprfnxNzyLvWzQJ7/Hts3q0zi97Qd9q ZdUtt3VZTl2ZFFjsbV56bEnYXfYqTOzG9TZdEjtAK+QEv049U6z+SuE6D5FzIAwNAR /raLn1ucFfu5FY563mgveclCA5R/8JD0dV9tk2IbIJTmgRfzzDKyXA4Sjw7yHrOzSS sQg5DlE65TaB+hhDWI7rzBxuwR/yql9QNSyCeUs3gza6nZmKjRNCxgrX6vHwOBQ5/x xcuFaOocjWSFoPXACHbI1+inSKReRobqxWVHJw6HJUKirqsy0GWpaHMfbyPoB/r6Jf eNkUIq3SFf1pg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtl8xxxu: tighten bounds checking in rtl8xxxu_read_efuse() From: Kalle Valo In-Reply-To: References: To: Dan Carpenter Cc: Jes Sorensen , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166210824025.24345.1875264756679909885.kvalo@kernel.org> Date: Fri, 2 Sep 2022 08:44:03 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter wrote: > There some bounds checking to ensure that "map_addr" is not out of > bounds before the start of the loop. But the checking needs to be > done as we iterate through the loop because "map_addr" gets larger as > we iterate. > > Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)") > Signed-off-by: Dan Carpenter > Acked-by: Jes Sorensen Patch applied to wireless-next.git, thanks. 620d5eaeb905 wifi: rtl8xxxu: tighten bounds checking in rtl8xxxu_read_efuse() -- https://patchwork.kernel.org/project/linux-wireless/patch/Yv8eGLdBslLAk3Ct@kili/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches