Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp2089612rwe; Fri, 2 Sep 2022 08:20:08 -0700 (PDT) X-Google-Smtp-Source: AA6agR767yrT+XoGV9pe97QX0KZ7ajuaFjAxyLdYMhvGTx570NY0rZCLUsktnTlxEd/upvVt2pax X-Received: by 2002:a05:6402:2714:b0:448:945f:99cd with SMTP id y20-20020a056402271400b00448945f99cdmr19103750edd.31.1662132007813; Fri, 02 Sep 2022 08:20:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662132007; cv=none; d=google.com; s=arc-20160816; b=MLhJ4m40VLqKO33n5l3BxWEl8Uz4Be7Frj2JoFtkLFygyOzZCntoAnziWXhL6ZiSrb SFQzdIEcaT/VhCwq7Am2/vrx8ZqynYO0/h9NmcWswa55CI9p4t+S+n7I9xSgUA/fh72R jU6LYaTstBmvLs/vaKUd+ddgLjvELafq4lS5wXgDvaUTv1BFk+Bb0npYzTtCdx48NsoK 08B3ZlJyeCyh3HPNjqVn/5glcJ3ScqVG7ao8/ARFJUD11jaMhymBpLjGQ5avs9iKW7dn tJilDRriY3aFmPkex+nn8/Z8A3BKVrQjPUMVwcezh8XVc25Pn/u0dk78vLO9SdEnDuOk +CuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=oxVqXtE/hinD1AroStGketJT7ozjTP3PmCtG0YZC1Y0=; b=FY9J7/klOTkPq7dFIGU4aYUVUMOLp3PmtGZOa1X9UckY3XfGGvFGwJP+uDj6edHv7m BbGIQgr97AfMmDZYNwc97zp2InvH7/wHPao6M69rAyz2U3bfc1xDjGCPisx/XhxRWfB9 O04T/DWEE7s9ix4tX4447pWBSqwM0PndvANwCv9Mp8Q5AwM/QqXiv1wTufzfkU8czlen 4x98GFxzNSJFkTTZxkhOTN3Ljtk55V774JcLuMfzULqe5ULcJSy8NBAfXChR/39WjsJd kLY7b/iW4JRPIT+rgb2Gh99uSoBMVyR/6/MDRzBXYMwu21b3C/uR8u69JtR6wVKuN5Qe 3Mrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=rWpi10Gi; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd32-20020a1709076e2000b00718d1cddac1si487357ejc.833.2022.09.02.08.19.46; Fri, 02 Sep 2022 08:20:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=rWpi10Gi; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236855AbiIBPNH (ORCPT + 64 others); Fri, 2 Sep 2022 11:13:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236325AbiIBPM1 (ORCPT ); Fri, 2 Sep 2022 11:12:27 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64C102495D; Fri, 2 Sep 2022 07:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=oxVqXtE/hinD1AroStGketJT7ozjTP3PmCtG0YZC1Y0=; t=1662129813; x=1663339413; b=rWpi10GiKcQR41CBIodi2aNvN9Azs0zx06qb0W4JVJGek0N iNgY1pzjPSlj309AT820Doft8bX/dcPQ3YWJtQGsTSxEZcK1ifIYJwdHk9ASvWXiaUxOg82TpsSJ9 jOPLr0larvxg0axLz8o7MufYg+eKK+b796RjIOYws/LstoOh5ZeQ2T7RajiTHalKFcJJaLUkcLH/E ZDoZR0Ih9Na/CS/VL4Q/Doebu7qOok8agknz+z5QkDkLXujvtnmaSc1OIGjaqeItglAjAK0Vmo9Vn uJND1WEyIP/wFgNFMLG4jzuDdYsJY9qNwvlepoXXBpBm/yUOq+cCr+zr3LeSMnkw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1oU7tJ-006D9j-2u; Fri, 02 Sep 2022 16:43:30 +0200 Message-ID: <0041cbac8840b51d16c6a5487a332a37effbb264.camel@sipsolutions.net> Subject: Re: [PATCH v1] net/mac80211/agg-tx: check the return value of rcu_dereference_protected_tid_tx() From: Johannes Berg To: Li Zhong , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Date: Fri, 02 Sep 2022 16:43:26 +0200 In-Reply-To: <20220902075725.2214351-1-floridsleeves@gmail.com> References: <20220902075725.2214351-1-floridsleeves@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2022-09-02 at 00:57 -0700, Li Zhong wrote: > From: lily >=20 > Check the return value of rcu_dereference_protected_tid_tx(), which > could be NULL and result in null pointer dereference if not checked. >=20 Except ... it can't happen? johannes