Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp2291712rwb; Sun, 4 Sep 2022 12:32:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR6L1kluZUj3LavNjLQ7mffiGZttPC9JSVIPex07BcokaE+lIRPVjQaMGnf0grwU06oznG41 X-Received: by 2002:a65:42cc:0:b0:431:af8c:77e1 with SMTP id l12-20020a6542cc000000b00431af8c77e1mr9606628pgp.308.1662319970007; Sun, 04 Sep 2022 12:32:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662319969; cv=none; d=google.com; s=arc-20160816; b=k5h0tjWY/wKi4X9mHZVwP3ratfgzFuZ3qasx9kip1FcOxpndZfeeZ6hSwpZPugiR4t fozW1FjUuISEde0uTVCWVnofZW6QuAx4AxTJpMDB/Ht2CmSUWTXTZ85XaxI0PytkKDoN aEW3bqREQcokZkl3OsDzHDA0osv1M8+ZYtgqx8FKAOTfHO3hrrSp8FFobvZweGuJLSnp V+gE2Kf3S6k2p6cACO3lKPVuWb5qxQTRnPaZfWRS45ZFpfrll4bAhsM8A1bJF58nOwYM 2txSBI5eA0+6uPGxeY7jGS/Kbn54Z1SCYE29YbD6Nc0J1JE4Y51D4/XlaYmpTDWUEzcX iHtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1+JiEv6OTXxhirxB8/QAHAVnTuonH3D+PvgI/T871pU=; b=lDFVseZXkLPbmhiiaAwYmm24+Gszifxun5dJw2ba6IvX9yNhMx365sI6vOr1WmOKdH j9gFTew9anQuLtYzF9U5P91mxyYMtcZLo74jMAeC3wglfGQ2J2Obg5PpBrtiGRDP/FPS k2n181DlS7GyOrlXl42kosOe6xezg5crOQFScAEJZjWtlAhC3iXW+4sGdZdlEsE57+/t tsXkqtcHkpqlMS29gUszQmOglRO+TDvQk+KR55O/rVuCYpSYdzlCZkJjgOik9X0F5HuS CsC7QlLo+f4mvxQxaTeMoypLEa9eA4PZCcFbyAGFsf910+50CFPQ9JzNh2blDGQwnFb0 YeEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=eERwWggZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v202-20020a6361d3000000b004343046d7c4si3635565pgb.184.2022.09.04.12.32.41; Sun, 04 Sep 2022 12:32:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=eERwWggZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234865AbiIDT3o (ORCPT + 64 others); Sun, 4 Sep 2022 15:29:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234871AbiIDT3a (ORCPT ); Sun, 4 Sep 2022 15:29:30 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 446AAE23 for ; Sun, 4 Sep 2022 12:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=1+JiEv6OTXxhirxB8/QAHAVnTuonH3D+PvgI/T871pU=; t=1662319763; x=1663529363; b=eERwWggZfYPLNatD+HnuE8xVk10xzSb5yUFzom3P/s8DWyr mPAYnVG0AYvX1gmLoZXSsQ0GUU4mKXDEs/DhMF9tcYCao/xdOglgmgnp8M9DFIpArs+AVNco0BBgl dZJugIVtcYdr4hBEcWenTPCvYmWkqXskOA2dmDj1bZGkVQz6VJq4YgcQ7SFfPje9vpR7kBZAIc7Gh G9wj08OK63pLOZ2TZvEnCppu9juTnnogAyD/XgoLosa6NPARhuVLnjbDpyxff4+Bz4FaanKJ47rdx GXdkf+Xb3XzLjFsu+xOVSR2d0GuL6rDE4eUwloMLtQWzOA//6ogCMpqGtPJNH5iw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1oUvJ2-007pTZ-0F; Sun, 04 Sep 2022 21:29:20 +0200 From: Johannes Berg To: linux-wireless@vger.kernel.org Cc: Johannes Berg , Solomon Peachy Subject: [PATCH 11/12] wifi: cw1200: use get_unaligned_le64() Date: Sun, 4 Sep 2022 21:29:11 +0200 Message-Id: <20220904212910.a5c9ea122f0f.If786a66f8fd9d45659cd5a2532cf395e21334453@changeid> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220904212910.8169e8c9090c.I0357e80cc86be2d4ac6205d1f53568444dcf7c9b@changeid> References: <20220904212910.8169e8c9090c.I0357e80cc86be2d4ac6205d1f53568444dcf7c9b@changeid> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg Instead of the code here that copies into a variable first and then flips endianness, which confuses sparse, just directly use get_unaligned_le64(). Signed-off-by: Johannes Berg --- Cc: Solomon Peachy --- drivers/net/wireless/st/cw1200/txrx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/st/cw1200/txrx.c b/drivers/net/wireless/st/cw1200/txrx.c index ab19e0403dc2..6894b919ff94 100644 --- a/drivers/net/wireless/st/cw1200/txrx.c +++ b/drivers/net/wireless/st/cw1200/txrx.c @@ -1142,8 +1142,7 @@ void cw1200_rx_cb(struct cw1200_common *priv, /* Remove TSF from the end of frame */ if (arg->flags & WSM_RX_STATUS_TSF_INCLUDED) { - memcpy(&hdr->mactime, skb->data + skb->len - 8, 8); - hdr->mactime = le64_to_cpu(hdr->mactime); + hdr->mactime = get_unaligned_le64(skb->data + skb->len - 8); if (skb->len >= 8) skb_trim(skb, skb->len - 8); } else { -- 2.37.2