Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org,
        Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 04/12] wifi: rndis_wlan: fix array of flexible structures warning
References: <20220904212910.8169e8c9090c.I0357e80cc86be2d4ac6205d1f53568444dcf7c9b@changeid>
        <20220904212910.0e7ce5fdbcfb.I972158734def3f93b93a3858a087cbc2cca6337e@changeid>
Date:   Mon, 05 Sep 2022 18:39:58 +0300
In-Reply-To: <20220904212910.0e7ce5fdbcfb.I972158734def3f93b93a3858a087cbc2cca6337e@changeid>
        (Johannes Berg's message of "Sun, 4 Sep 2022 21:29:04 +0200")
Message-ID: <87tu5lde41.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Johannes Berg <johannes@sipsolutions.net> writes:

> From: Johannes Berg <johannes.berg@intel.com>
>
> Use "u8 bssid_data[]" with an appropriate cast. No binary
> changes.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  drivers/net/wireless/rndis_wlan.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
> index 325933217b41..82a7458e01ae 100644
> --- a/drivers/net/wireless/rndis_wlan.c
> +++ b/drivers/net/wireless/rndis_wlan.c
> @@ -251,7 +251,7 @@ struct ndis_80211_bssid_ex {
>  
>  struct ndis_80211_bssid_list_ex {
>  	__le32 num_items;
> -	struct ndis_80211_bssid_ex bssid[];
> +	u8 bssid_data[];
>  } __packed;
>  
>  struct ndis_80211_fixed_ies {
> @@ -2084,7 +2084,8 @@ static int rndis_check_bssid_list(struct usbnet *usbdev, u8 *match_bssid,
>  	netdev_dbg(usbdev->net, "%s(): buflen: %d\n", __func__, len);
>  
>  	bssid_len = 0;
> -	bssid = next_bssid_list_item(bssid_list->bssid, &bssid_len, buf, len);
> +	bssid = next_bssid_list_item((void *)bssid_list->bssid_data,
> +				     &bssid_len, buf, len);

Same comment as in patch 2, I just feel the code gets worse because of a
compiler warning.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches