Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <95588bd2352048ea0a8016153e1fe7abb26a62e2.camel@sipsolutions.net>
Subject: Re: [PATCH v3 03/12] mac80211: S1G beacon/short beacon support
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Kieran Frewen <kieran.frewen@morsemicro.com>
Cc:     linux-wireless@vger.kernel.org, quic_jjohnson@quicinc.com
Date:   Tue, 06 Sep 2022 11:40:17 +0200
In-Reply-To: <20220906044812.7609-4-kieran.frewen@morsemicro.com>
References: <20220906044812.7609-1-kieran.frewen@morsemicro.com>
         <20220906044812.7609-4-kieran.frewen@morsemicro.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-09-06 at 16:48 +1200, Kieran Frewen wrote:
> If configured, use the S1G short beacon format. The S1G short beacon
> format includes a limited set of information elements.

Could you be more specific? Is there really no reason to think that this
limited set might need to be set partially by hostapd?

> -	if (beacon->tail)
> +	if (beacon->tail && !is_short)
>  		skb_put_data(skb, beacon->tail, beacon->tail_len);

Asking since you do this here.

johannes