Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d58015ea844a0b56ea39de5f63b7f6889afcd918.camel@sipsolutions.net>
Subject: Re: [PATCH v3 03/12] mac80211: S1G beacon/short beacon support
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Kieran Frewen <kieran.frewen@morsemicro.com>
Cc:     linux-wireless@vger.kernel.org, quic_jjohnson@quicinc.com
Date:   Tue, 06 Sep 2022 11:43:31 +0200
In-Reply-To: <20220906044812.7609-4-kieran.frewen@morsemicro.com>
References: <20220906044812.7609-1-kieran.frewen@morsemicro.com>
         <20220906044812.7609-4-kieran.frewen@morsemicro.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-09-06 at 16:48 +1200, Kieran Frewen wrote:
> If configured, use the S1G short beacon format. The S1G short beacon
> format includes a limited set of information elements.
>=20
> Signed-off-by: Kieran Frewen <kieran.frewen@morsemicro.com>
> ---
>  include/net/cfg80211.h     |  2 +-
>  include/net/mac80211.h     |  1 +
>  net/mac80211/cfg.c         |  1 +
>  net/mac80211/ieee80211_i.h |  1 +
>  net/mac80211/tx.c          | 14 +++++++++++++-
>  5 files changed, 17 insertions(+), 2 deletions(-)
>=20
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 945e7700de66..b750b2ad246b 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -1328,7 +1328,7 @@ struct cfg80211_ap_settings {
> =20
>  	struct cfg80211_beacon_data beacon;
> =20
> -	int beacon_interval, dtim_period;
> +	int beacon_interval, dtim_period, short_beacon_period;
>=20

One way or the other, this doesn't belong into this patch - you should
reorder so cfg80211 comes first and then mac80211 can use it, and then
this change goes into the cfg80211 patch.

johannes