Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c2b9720065e9d8b1b364a4dbb851cd4153b1f093.camel@sipsolutions.net>
Subject: Re: [PATCH v3 06/12] mac80211: support ieee80211_ext format
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Kieran Frewen <kieran.frewen@morsemicro.com>
Cc:     linux-wireless@vger.kernel.org, quic_jjohnson@quicinc.com
Date:   Tue, 06 Sep 2022 11:45:29 +0200
In-Reply-To: <20220906044812.7609-7-kieran.frewen@morsemicro.com>
References: <20220906044812.7609-1-kieran.frewen@morsemicro.com>
         <20220906044812.7609-7-kieran.frewen@morsemicro.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-09-06 at 16:48 +1200, Kieran Frewen wrote:
>=20
> +		if (ieee80211_is_s1g_beacon(fc))

maybe use "if (ext_hdr)" here so it's easier to understand? Even for
static checkers :)

> +			rx.sta =3D sta_info_get_bss(prev, ext_hdr->u.s1g_beacon.sa);
> +		else
> +			rx.sta =3D sta_info_get_bss(prev, hdr->addr2);
>  		rx.sdata =3D prev;
>  		ieee80211_rx_for_interface(&rx, skb, false);
> =20
> @@ -4999,6 +5007,10 @@ static void __ieee80211_rx_handle_packet(struct ie=
ee80211_hw *hw,
>  	}
> =20
>  	if (prev) {
> +		if (ieee80211_is_s1g_beacon(fc))
> +			rx.sta =3D sta_info_get_bss(prev, ext_hdr->u.s1g_beacon.sa);
> +		else
> +			rx.sta =3D sta_info_get_bss(prev, hdr->addr2);
>=20

here too, I guess

johannes