Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4184a31465de442c3f8a66f06aa4c59e77e4c237.camel@sipsolutions.net>
Subject: Re: [PATCH v3 07/12] mac80211: S1G capabilities information element
 in probe request
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Kieran Frewen <kieran.frewen@morsemicro.com>
Cc:     linux-wireless@vger.kernel.org, quic_jjohnson@quicinc.com
Date:   Tue, 06 Sep 2022 11:47:22 +0200
In-Reply-To: <20220906044812.7609-8-kieran.frewen@morsemicro.com>
References: <20220906044812.7609-1-kieran.frewen@morsemicro.com>
         <20220906044812.7609-8-kieran.frewen@morsemicro.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk


Feels like somewhere in this patch you should consider the size of the
new element?
=20
>  /* channel management */
>  bool ieee80211_chandef_ht_oper(const struct ieee80211_ht_operation *ht_o=
per,
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index 53826c663723..78e8c286011e 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -1857,6 +1857,12 @@ static int ieee80211_build_preq_ies_band(struct ie=
ee80211_sub_if_data *sdata,
>  	rate_flags =3D ieee80211_chandef_rate_flags(chandef);
>  	shift =3D ieee80211_chandef_get_shift(chandef);
> =20
> +	/* For direct mac80211 scan (probe request), add S1G IE and consider it=
s override bits */
> +	if (band =3D=3D NL80211_BAND_S1GHZ) {
> +		pos =3D ieee80211_ie_build_s1g_cap(pos, &sband->s1g_cap);
> +		goto done;
> +	}
>=20

Though off the top of my head I'm not really sure how it works for the
other bits.

johannes