Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4132381rwb; Tue, 6 Sep 2022 03:06:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR5uwVCnyReP8I8kYuck5GoDA1jRfCUFc2rPvJFnHtqmLpHW4WBhSCQfuK3zJrC3lGPta99S X-Received: by 2002:a05:6402:43c4:b0:43b:c5eb:c9dd with SMTP id p4-20020a05640243c400b0043bc5ebc9ddmr46045645edc.402.1662458801033; Tue, 06 Sep 2022 03:06:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662458801; cv=none; d=google.com; s=arc-20160816; b=yO8dE9Mbs+tSfsXYVR7mN7SKKbBGRObmpmHnl98gvr+sUbAYP4En9pojHlVL5grcmZ KM8os76D3fizNFuW99+oxzIFs+Q+hL7zISZitany3rd6nm+jNBIlpPVISYkgPMUHeDAJ EA6aPOEhJ9SXNHK7iZ1A+9IJVsxdFNyG9cLnc3ohgW3qCfzxYJFuKtB1Pw6DkKOxTZhh hvI7UPoxikjZ18POGFvoGtnYq3YLh7Zw42AS+NQ/4fsf1YxW0TA8zlptza/VnIwXPcZR yqs/R/Lrx+Gs/G0673bvDf3BLD+EPvZxuxwjcG5hHyZSQZgITgXxavs/lb8cv8quj3SB YJ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=Dqu5rUufUiV64KWQvdRnmiG6kkNRleAX1CZL4L3NS4Q=; b=PYAEcwQ2Ru7mwS0BkjbvuLjM8/rukA99vHNOGwPf3rN4CQ2p9Y3w/MHulSeZpvrPAf kpRZq3KdjFT4xcABa5KaRQifWIqpTFH8cYYGWG41TQ8Bsfc3sL6teWvcB25cU575W4pW e7K76gYaYuP03J0ABc6DK2gFZsc4ZV02nJOUKtgZUQqJUkXUhaeDK8DfHZWjROI9RKxa ENbLBwHPRPy27xbziQlpvC5grhXL0SC+jYPhvc36mvrZ44DAgxH4hFk2fAxQy9lw0xPJ XYGnuZi7E5opMJpL38pKu2viz4i+DEMMgtrI7Z8bjOM5a/z4lJ1XbvKB5+ZYoQXqjOhk VpyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=sPuIZDeG; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q8-20020a50cc88000000b0043d7a3c3cddsi8489405edi.408.2022.09.06.03.06.24; Tue, 06 Sep 2022 03:06:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=sPuIZDeG; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232318AbiIFJvl (ORCPT + 64 others); Tue, 6 Sep 2022 05:51:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239147AbiIFJvg (ORCPT ); Tue, 6 Sep 2022 05:51:36 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B517E786CC for ; Tue, 6 Sep 2022 02:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=Dqu5rUufUiV64KWQvdRnmiG6kkNRleAX1CZL4L3NS4Q=; t=1662457895; x=1663667495; b=sPuIZDeGLLzmWHkbCBaHAITsX+DxmgnWajYpnQp31XlT6GW lPqhB0/PxX90P8pw8mTpzS2Pa8g0WGYA6vGAfdtFrk0Swxth69sO2nTihs2fD8zLl24jo4tLBVO2R lu7nV6X3/uRg7n06Ri/uyuXzNkIMQdWvn59apefShNSJFsjiaudqS+q8h94WdixYbHrKsMlqccq7z t/CX3rIp5e98HAjNIEaGYIjwI9gb+jZ3wrvF/aDZuNjue5v8rJ4CrS8qli6i0dsHPfnmufuXPtcFl tCjQk2H7EUwJFqTILVfik/HQiQNMb3kYhsAFH9WQf7w2qv81nIQwJ62dNsmebHdw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1oVVEz-009N0v-10; Tue, 06 Sep 2022 11:51:33 +0200 Message-ID: Subject: Re: [PATCH v3 11/12] cfg80211: support for calculating S1G bitrates From: Johannes Berg To: Kieran Frewen Cc: linux-wireless@vger.kernel.org, quic_jjohnson@quicinc.com Date: Tue, 06 Sep 2022 11:51:32 +0200 In-Reply-To: <20220906044812.7609-12-kieran.frewen@morsemicro.com> References: <20220906044812.7609-1-kieran.frewen@morsemicro.com> <20220906044812.7609-12-kieran.frewen@morsemicro.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2022-09-06 at 16:48 +1200, Kieran Frewen wrote: >=20 > +warn: > + if (!rate->bw && !rate->mcs && !rate->nss) > + pr_debug("%s: rx status was not received yet!", __func__); That part seems ... odd? Why not just warn? johannes