Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52e4bd3a7d24fca06a507f86fe23d23a552c7c2d.camel@sipsolutions.net>
Subject: Re: [PATCH 3/7] mac80211: add combined power type definition for 6
 GHz
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Aditya Kumar Singh <quic_adisi@quicinc.com>,
        linux-wireless@vger.kernel.org
Date:   Tue, 06 Sep 2022 13:01:22 +0200
In-Reply-To: <20220704102341.5692-4-quic_adisi@quicinc.com>
References: <20220704102341.5692-1-quic_adisi@quicinc.com>
         <20220704102341.5692-4-quic_adisi@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-07-04 at 15:53 +0530, Aditya Kumar Singh wrote:
>=20
> +/**
> + * enum nl80211_regulatory_power_modes - 6 GHz regulatory power
> + *					 modes
> + * @NL80211_REG_AP_LPI: Low Power Indoor (Access Point)
> + * @NL80211_REG_AP_SP: Standard Power (Access Point)
> + * @NL80211_REG_AP_VLP: Very Low Power (Access Point)
> + * @NL80211_REG_REGULAR_CLIENT_LPI: Low Power Indoor (Regular
> + *				    or Default Client)

REG_REGULAR reads a bit weird, and anyway "REG" as the prefix for
"regulatory_power_mode" is a bit strange?

Maybe use something like REG_PWR_MODE_... ?

> +++ b/net/wireless/util.c
> @@ -190,6 +190,66 @@ struct ieee80211_channel *ieee80211_get_channel_khz(=
struct wiphy *wiphy,
>  }
>  EXPORT_SYMBOL(ieee80211_get_channel_khz);
> =20
> +enum nl80211_regulatory_power_modes
> +ieee80211_ap_reg_power_to_reg_power_mode(enum ieee80211_ap_reg_power ap_=
type)
> +{
> +	switch (ap_type) {
> +	case IEEE80211_REG_LPI_AP:
> +		return NL80211_REG_AP_LPI;
> +	case IEEE80211_REG_SP_AP:
> +		return NL80211_REG_AP_SP;
> +	case IEEE80211_REG_VLP_AP:
> +		return NL80211_REG_AP_VLP;
> +	default:
> +		return NL80211_REG_MAX_POWER_MODES + 1;
> +	}
> +}
> +EXPORT_SYMBOL(ieee80211_ap_reg_power_to_reg_power_mode);

What is the use of that, why export it? Same for the other function.

johannes