Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4929560rwb; Tue, 6 Sep 2022 15:24:29 -0700 (PDT) X-Google-Smtp-Source: AA6agR66s2bXhQi2YCOu9IUS4fle+89yZ7Ngy8NubXdrXyIemQBeDfPfFJaSr/lHFbgKymvKPRQl X-Received: by 2002:a17:906:bc87:b0:73d:bacd:84e2 with SMTP id lv7-20020a170906bc8700b0073dbacd84e2mr384268ejb.494.1662503068831; Tue, 06 Sep 2022 15:24:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662503068; cv=none; d=google.com; s=arc-20160816; b=hGkz+EXL7zgeydK2dSVO3XxMvr7F+N2S/LcRrEtJA47jKd0jGY6HMSOSeeXjGjLJhX QrHkBhCwUFWBccfeKkJtFdjuCK8Aonw6aGpGhEoS7f/TapqxHTwTGNbvvsjUigyH/+Hy 2QRGesWnLtlXpgpThsfjY5dSFvR/ly+3lQYtlM1YCnVxEPV91Cch6u964Zq2PaIMJFum u02f+MvTU7rfVrVPOYUAI3iAIkKf7+4+IZQUrxzPCzK9l5Nh7oHNGjwznCSQVwSbAL2F VtG3rrECl9+NTT6p3OI2LH+jJV5YIEx1P95FGMbyywBRTdyHICFyYdnc60a7vmQzlAGe 2nnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9+9emoww3hJUz6+xI7xquY0LNL2jhluEPZeZV1SQ388=; b=qI2hwhBqtNpCnmQB9RI6ETtcmm80CjjyLVUSCOrR2RTrIecofJXVZjaS3iKqxsMrTN Mfc13N726EUviim3GNhPkTHubkBjtCfh+2JNbWYpGHs84n3wx5fx5Ru4s24MApyyAulZ 1wrQElPRdjTrhf13+Guy7JjcSsoxOY7BBuPeGx5KOTVVHc/T18zFpIbG3I4QHZ9AOOiP sL5FkbQvnTGfchbsEVCNGLk+M7x7GpXoYjWsWGnAVo9jaUNJHj6Eo2g8V+A8yLnysrn6 /qzrJp2AoYNrF/9v4+4IVFw68thozlXHjPfrUojdVuV4R5dCle23WQhAY+4UB57w8iPa dX/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CJoqjIKy; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i18-20020a05640242d200b0043ce8b2c72dsi12827923edc.36.2022.09.06.15.24.12; Tue, 06 Sep 2022 15:24:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CJoqjIKy; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229742AbiIFWW2 (ORCPT + 64 others); Tue, 6 Sep 2022 18:22:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbiIFWW1 (ORCPT ); Tue, 6 Sep 2022 18:22:27 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA63AA4B06 for ; Tue, 6 Sep 2022 15:22:26 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id 78so11827321pgb.13 for ; Tue, 06 Sep 2022 15:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=9+9emoww3hJUz6+xI7xquY0LNL2jhluEPZeZV1SQ388=; b=CJoqjIKy0n86oTWooLaNgt0B7dRumeuzRd6gmAHFNpfPLW5bZlCr/KeRLEI5Ag0wRu gjTT8dDdgxxRnFhTaZvQ/hUqfoCYtRwMcc4MGdlTSL34jBWzvJd/nZtwzNJXG9vLU/f2 GWKhrx96p/IBfo04UwsHOi861ni6tj89b4zSE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=9+9emoww3hJUz6+xI7xquY0LNL2jhluEPZeZV1SQ388=; b=78mEJfms/rDkD2vpJNnyRqE7V5ieoEp5O7Q4d5dXrRXQ5J8YQHBuNes6Tls1LqCzRR /JiinBkDJXtTJzRjjxYFhE76rkQrxPGy7OotBHKJswGdP+XXzgswFtmGo8hCuAJYuixD YXF+JnIMd+mdG6NWIPvn3Ztl/FjAib8tWss4S4V1PWfe2odmnIKbISn4KvibLrsEgG/g 6LuLEHG6gGdWjn+iom/Z65rXw4GiXheQqJPNENw2ekKFw0fFegRk3BTlYZfPQBE8zU30 LKIdzcDM9ikejsluYEdBODvmPJ84zMPmjfkTn9M4LBapOFDjop7ZIoMg9iawVri2JZSL Pk8A== X-Gm-Message-State: ACgBeo1GUFv+SzBTC0IFTddysnvroaYJNLCMLG+HybgQnPchoeMRUsoO pGLiaI19Pvr7QHexIxcHxuyZXcRn8URDEA== X-Received: by 2002:a63:a1f:0:b0:434:dd36:c639 with SMTP id 31-20020a630a1f000000b00434dd36c639mr668234pgk.165.1662502946402; Tue, 06 Sep 2022 15:22:26 -0700 (PDT) Received: from google.com ([2620:15c:202:201:922a:25d3:a5a:7290]) by smtp.gmail.com with ESMTPSA id f13-20020a170902684d00b0016d692ff95esm6103983pln.133.2022.09.06.15.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 15:22:25 -0700 (PDT) Date: Tue, 6 Sep 2022 15:22:23 -0700 From: Brian Norris To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Johannes Berg Subject: Re: [PATCH 08/12] wifi: mwifiex: fix endian conversion Message-ID: References: <20220904212910.8169e8c9090c.I0357e80cc86be2d4ac6205d1f53568444dcf7c9b@changeid> <20220904212910.a32e45adb2b2.I8c966b07c0bf7be4485967b044d9dad3f4772a27@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220904212910.a32e45adb2b2.I8c966b07c0bf7be4485967b044d9dad3f4772a27@changeid> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, Sep 04, 2022 at 09:29:08PM +0200, Johannes Berg wrote: > From: Johannes Berg > > Clearly the value should be converted and then compared, > not the result of the comparison be converted. No binary > changes on x86. > > Signed-off-by: Johannes Berg Reviewed-by: Brian Norris