Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp5347283rwb; Wed, 7 Sep 2022 01:04:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR5fSg2bqsvMlzCPpi66leEzcTdXPU44TXIbrFFbW1xCnrAqdRg67ha4t288Z2ewuQGX8qsZ X-Received: by 2002:a17:902:c403:b0:176:65a9:2de8 with SMTP id k3-20020a170902c40300b0017665a92de8mr2445467plk.52.1662537890636; Wed, 07 Sep 2022 01:04:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662537890; cv=none; d=google.com; s=arc-20160816; b=DagyQCnIGzs8Om3/jGrVy4MGaZTVaSqFWfn6+MtrLznPYVX8JYyJSiyMrgdWbaaZj/ 46ZQgHuZ3AtwULz+hDNPtDO4jjIAxNrzDubOGnxvpsiWGsqzmXA/gSCkOhbCKjw2ewQj LE/gMNOpZM7KjidvkQWQZ1Hcp9WO0HhAVvlEw0XA+SemPjEw0GkPocBAcrvBQEG1TW9y yo3vh9FSznImtCh8Wc4JtVRlX6f3fUdojiaf2cyGA7vEmBEdSI8xgSNHa13P5k8nwo9m RW+b0n5KOicoOQOKi6bPxMZfrusMYqJBz3X8lyLordQNE1A3iu+zu4NEGCPeJ6bdGGjm 5Ktg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=hgXyK587k9de6iFTfvHL/hRzP1hLuyuC7hzay8mpGVg=; b=b4scugMXCIz1r1E/Frgo7c660mn04pB7/JL/6BP/42lVTMvxxeuNqEFoYEs5dCO287 /qqiKqgbK2lAGKdI6f/jn0RkvDpSNkBIqvmftcsV/eqhDyNaNvATzdCIRM5G9a/7nkL/ +3xyShNJg9L46U8HZEwVUqYG6UrZhyRELA00MJ1gqgU+8TzDbxtmSIL+/n/h3JYOqcVQ hA9EbhNNJ70B/rikzcOXpmQiWI8RV11LxN7vMAWIFBJz7F7hwZ4+/voPwwxb9N7aZKkd QA0lux7gvQQlyntvS+8+2EJBYUiSoYRssi1g6i4gQZmM9XmnI8xE6v+KVZ2KTp9jkUv4 1dBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MMUHGuQS; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q3-20020a17090311c300b00174b04f2de2si18718596plh.281.2022.09.07.01.04.42; Wed, 07 Sep 2022 01:04:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MMUHGuQS; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230228AbiIGIDE (ORCPT + 64 others); Wed, 7 Sep 2022 04:03:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230226AbiIGICi (ORCPT ); Wed, 7 Sep 2022 04:02:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77EE3AB192 for ; Wed, 7 Sep 2022 01:02:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A31C4617C0 for ; Wed, 7 Sep 2022 08:02:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 576DAC4314F; Wed, 7 Sep 2022 08:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662537736; bh=9KAqY7aetdItbTsJtRpGHaOUvbqpChlrc5OGfYixmoE=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=MMUHGuQS/zyP7d2K9aLX4AVMwpWd8gCcRKfArlBKkB1ZNa5jwoDMtHVJRzesp0jS/ /ErOO51958HdVa8XN3GTtpIn6gnGyIUs7/QIPaIBxqdugweIJf+/M945QQJe6+AVRm eqlZo5p6j9lTmrgg39Iqm6Gc9c4pKvI+uCJLAefWw7n99fDAq0KR6FnpvQ+fwplm5g eDRbUavIo4yGMHUIq8dxemCJei2SWYMZNh5ZF6yDn0ybdglH4+urOxxjnktspA4e7Z H4I4h97Piqnp7r+zm7+mTYjBXw5qwAxAx0HB0NPFV1JIYxkGj5HsGnVDuR+YvOvZMf jW2GwpYmnjWRg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: rtl8xxxu: Fix skb misuse in TX queue selection From: Kalle Valo In-Reply-To: <7fa4819a-4f20-b2af-b7a6-8ee01ac49295@gmail.com> References: <7fa4819a-4f20-b2af-b7a6-8ee01ac49295@gmail.com> To: Bitterblue Smith Cc: linux-wireless@vger.kernel.org, Jes.Sorensen@gmail.com User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166253773363.23292.14170408152286611932.kvalo@kernel.org> Date: Wed, 7 Sep 2022 08:02:15 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Bitterblue Smith wrote: > rtl8xxxu_queue_select() selects the wrong TX queues because it's > reading memory from the wrong address. It expects to find ieee80211_hdr > at skb->data, but that's not the case after skb_push(). Move the call > to rtl8xxxu_queue_select() before the call to skb_push(). > > Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)") > Signed-off-by: Bitterblue Smith Patch applied to wireless-next.git, thanks. edd5747aa12e wifi: rtl8xxxu: Fix skb misuse in TX queue selection -- https://patchwork.kernel.org/project/linux-wireless/patch/7fa4819a-4f20-b2af-b7a6-8ee01ac49295@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches