Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220907134450.1183045-1-toke@toke.dk>
In-Reply-To: <20220907134450.1183045-1-toke@toke.dk>
From:   Emmanuel Grumbach <egrumbach@gmail.com>
Date:   Thu, 8 Sep 2022 11:27:41 +0300
Message-ID: <CANUX_P3NRqD2YWfkFri37F982QVaCASfyz2qaicGjc9wJ6mDYQ@mail.gmail.com>
Subject: Re: [PATCH] iwlwifi: Mark IWLMEI as broken
To:     =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>
Cc:     Gregory Greenman <gregory.greenman@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Kalle Valo <kvalo@kernel.org>,
        Ayala Beker <ayala.beker@intel.com>,
        linux-wireless@vger.kernel.org,
        =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@redhat.com>,
        Golan Ben Ami <golan.ben.ami@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,


On Wed, Sep 7, 2022 at 5:02 PM Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.=
dk> wrote:
>
> From: Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com>
>
> The iwlmei driver breaks iwlwifi when returning from suspend; the bug
> report[0] has been open for four months now, and now fix seems to be
> forthcoming. Since just disabling the iwlmei driver works as a workaround=
,
> let's mark the config option as broken until it can be fixed properly.
>
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=3D215937
>
> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation w=
ith CSME")
> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com>

I am not very proud of this, to say the least, but unfortunately,
despite Toke's patience and
his willingness to provide logs and all, I couldn't find the time to fix th=
is.
We had tested against NetworkManager wpa_s, but not against iwd.
From the start, we thought distro wouldn't enable this and this is why
we disabled iwlmei by default.
This driver is meant to be used by specific groups that need this and
they'll know how to enable this
driver even if it is marked as BROKEN.

This is why, with a heavy heart:
Acked-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

I'd also suggest to CC this to stable 5.17+

Thanks Toke and Sorry!

> ---
>  drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wir=
eless/intel/iwlwifi/Kconfig
> index a647a406b87b..b20409f8c13a 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -140,6 +140,7 @@ config IWLMEI
>         depends on INTEL_MEI
>         depends on PM
>         depends on CFG80211
> +       depends on BROKEN
>         help
>           Enables the iwlmei kernel module.
>
> --
> 2.37.2
>