Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Robert Marko <robert.marko@sartura.hr>
Cc:     Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
        ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath11k: Enable threaded NAPI on WCN6750
In-Reply-To: <CA+HBbNEAgMPKJFrAYGUT1x-XAX81tTNj4W5xgW-bYSm5j_r_4w@mail.gmail.com>
        (Robert Marko's message of "Thu, 8 Sep 2022 10:49:30 +0200")
References: <20220720135113.15755-1-quic_mpubbise@quicinc.com>
        <20220720135113.15755-2-quic_mpubbise@quicinc.com>
        <87czceaqng.fsf@kernel.org>
        <dcc14883-51c9-c1bb-bbea-1b309eccedf2@quicinc.com>
        <CA+HBbNGEoSyfbs=FHtWyvBnG_jh9m=Q9KW=Pcfq+pDdHWEV4mw@mail.gmail.com>
        <7615c815-ca2e-c6f1-b627-6e10f1272442@quicinc.com>
        <CA+HBbNEm9GhYcXQ9gXEb=U4x=BZTDp4UBqF8eNH1N0uCBLdadQ@mail.gmail.com>
        <5c07bcd5-574c-b13b-44c2-ef8ed9f23cf0@quicinc.com>
        <878rmucqhu.fsf@kernel.org>
        <CA+HBbNEAgMPKJFrAYGUT1x-XAX81tTNj4W5xgW-bYSm5j_r_4w@mail.gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Date:   Thu, 08 Sep 2022 15:15:31 +0300
Message-ID: <87tu5i83ks.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Robert Marko <robert.marko@sartura.hr> writes:

> On Thu, Sep 8, 2022 at 8:46 AM Kalle Valo <kvalo@kernel.org> wrote:
>
>>
>> Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
>>
>> > On 9/2/2022 7:16 PM, Robert Marko wrote:
>> >> On Fri, Sep 2, 2022 at 3:42 PM Manikanta Pubbisetty
>> >> <quic_mpubbise@quicinc.com> wrote:
>> >>>
>> >>> On 9/2/2022 6:50 PM, Robert Marko wrote:
>> >>>> On Fri, Sep 2, 2022 at 3:18 PM Manikanta Pubbisetty
>> >>>> <quic_mpubbise@quicinc.com> wrote:
>> >>>>>
>> >>>>> Regardless of the chip family, even I feel that the tput changes like
>> >>>>> these should be tested on all the chipsets. Availability of the hardware
>> >>>>> and time are something which are stopping me in testing the changes on
>> >>>>> all supported targets.
>> >>>>>
>> >>>>> As I said, I had made the changes only to WCN6750 initially (using a
>> >>>>> hw_param). Can we take that approach for now and enable this for other
>> >>>>> targets only if required & upon thorough testing?
>> >>>>
>> >>>> I can tell you that on IPQ8074 threaded NAPI really improves perfromance.
>> >>>>
>> >>>
>> >>> Great. Do you have any test results on IPQ8074?
>> >>
>> >> I dont have full test results, but on Poco F2 Pro as the client @80MHz AX
>> >> I got ~720Mbps compared to ~550Mbps before.
>> >>
>> >> I can tell you that in OpenWrt, we have had it enabled for 6+ months
>> >> at this point
>> >> and its been really good.
>> >>
>> >
>> > That's a significant improvement, great to hear that. We have another
>> > strong reason to have this change in upstream driver.
>>
>> Indeed, thanks Robert. Is the code in openwrt similar as what
>> Manikanta's patch does?
>
> It's actually identical, we are also just calling dev_set_threaded
> before napi_enable.

Nice, even better :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches