Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Gregory Greenman <gregory.greenman@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Ayala Beker <ayala.beker@intel.com>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: Mark IWLMEI as broken
In-Reply-To: <87k06daysx.fsf@kernel.org>
References: <20220907134450.1183045-1-toke@toke.dk> <87k06daysx.fsf@kernel.org>
Date:   Fri, 09 Sep 2022 08:26:51 +0200
Message-ID: <87o7vpcbbo.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Kalle Valo <kvalo@kernel.org> writes:

> Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:
>
>> From: Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com>
>>
>> The iwlmei driver breaks iwlwifi when returning from suspend; the bug
>> report[0] has been open for four months now, and now fix seems to be
>
> s/now/no/? I can fix that.

Yeah, oops, sorry...

>> forthcoming. Since just disabling the iwlmei driver works as a workaroun=
d,
>> let's mark the config option as broken until it can be fixed properly.
>>
>> [0] https://bugzilla.kernel.org/show_bug.cgi?id=3D215937
>
> So does the bug only happen with iwd? Should I mention that in the
> commit log? It would be good to describe the conditions when the bug
> happens.

Well, what happens is that the interface ends up in the 'down' state
after coming back from suspend. And iwd doesn't touch the interface
state, but wpa_supplicant does, so the user-visible "my WiFi doesn't
work" thing only happens on iwd...

>> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation =
with CSME")
>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com>
>
> I assigned the patch to me on patchwork and will queue for v6.0.

Great, thanks!

-Toke