Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp5058870rwn; Mon, 12 Sep 2022 03:54:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR5rPGZLkSLxsNEXqTF/LCfPipPr+Ks7JkbXwApobpExlKQKgFYRLm3cn1LFlRYscri5EwoF X-Received: by 2002:aa7:d617:0:b0:44e:d2de:3fe1 with SMTP id c23-20020aa7d617000000b0044ed2de3fe1mr21722944edr.104.1662980098817; Mon, 12 Sep 2022 03:54:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662980098; cv=none; d=google.com; s=arc-20160816; b=CqBUTsJFdr8bJEyp+vaLZPZIOnC8pRhm6GYGbzFEnrbk3osDBVhF1uaplXHtJy08Fs TdoaiOE4AZ5lZbawB1iecU+NR+Kx3oHiWNPEp/GM/pN7ZgSkdzcQT+0dF8H8qYebE3mf iAZCKZYE3WS4DUBSQD1bLvl8b6cCL+0I7qnt1lLb89JYKJx12p3RO8iHe5FJ98Nu2WdJ YSXbHryCG5J+FMWe9Lj8CCgGtj34UCRSKv7nDo1l54j4kgzF8ekcRPiCgDkoeiThRmNV /i8oVGU925DjxhMUtpoIvlgYo7YqzYHbiel1bONX0swUojFoUYA23cxvSJBWDKDTNFb+ IF+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:user-agent:references:in-reply-to:subject:cc:to :from:dkim-signature; bh=GWmpLkDHOamaH18vVPfnc4F1h0ku9hgrS00WmUIaHd4=; b=z4sr8BQ66+o0FPQQKigJH6DaMtgTwYAP0AQksIpzXSIMPdCuWG+GFxYkE6Ta6PjvaQ wIVwQH01mt4RJW/lGNWf/1N1Sf8Gxz5Usevn7ZUtuQPdX2ohSgOKuMsD6XWWFjeuL8zR 194Oc9t7cY2DPVqwswfFtks4GB0S9Pzx96o37zL95+yuY8Qh6W+QoN/mlGVBdvnFYgAQ WE1CMfGPSMtjPap/Z9/2lJZR2igp5Gi7M1gCO+bV2iIVDlltH/XFp4stxoB6M+YL1gmB LSVWvNZajktH95EZ7phvyGoXZnRvNF5tfKq7c17U+0VaNYg2gMSWMtubBfXniuQd0k1Y iNBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GPVtZWPL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xh13-20020a170906da8d00b0073d5a794b43si7647381ejb.985.2022.09.12.03.54.37; Mon, 12 Sep 2022 03:54:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GPVtZWPL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229615AbiILKt0 (ORCPT + 64 others); Mon, 12 Sep 2022 06:49:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiILKtY (ORCPT ); Mon, 12 Sep 2022 06:49:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4018431368 for ; Mon, 12 Sep 2022 03:49:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE23160B52 for ; Mon, 12 Sep 2022 10:49:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F494C433C1; Mon, 12 Sep 2022 10:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662979763; bh=GWmpLkDHOamaH18vVPfnc4F1h0ku9hgrS00WmUIaHd4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GPVtZWPLpQyDW4JdxgKheDA/6H0tLlD3sgTpsGiB86JH1V3s/jgdInhvAyxwBm3zL OHtnci26mAAwfIUJ9Ieg8e8OZ/2H45cPPxF2XfndumxboewD0SrWxZiDMveVSOYZ4P C7p/3r10nxBx08og1c4kbpZ04pLF69KbHuXfBcOGFl9TMHILGkUxn2lpO0en8AJjGw aH1dkqCg6AimMfBjE68452nevXfiEan1qjj5FgP1yCxC3GHKFXhUG9qIFlKxoNQzZQ YQen1gq4TAG4Azu3Zs504nyYb+ODryhA8KwVtfMUniPbkTrj5Wp0PPisV+yCYLDD5M wN8mXuntltKuA== From: Kalle Valo To: Wen Gong Cc: Johannes Berg , linux-wireless , Subject: Re: [PATCH] wifi: mac80211: RCU-ify link STA pointers In-Reply-To: <24df3a0c-a312-d9b6-5840-1eacd79d824b@quicinc.com> (Wen Gong's message of "Mon, 12 Sep 2022 17:36:47 +0800") References: <24df3a0c-a312-d9b6-5840-1eacd79d824b@quicinc.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Mon, 12 Sep 2022 13:49:19 +0300 Message-ID: <87a67498b4.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong writes: > Hi Johannes, > > Currently for MLO test, the others links's rx_nss of struct > ieee80211_link_sta is still value 0 in ieee80211_set_associated(), > becaue they are not pass into ieee80211_sta_set_rx_nss() in > mac80211 except the deflink which means the primary link. > This lead driver get nss =3D 0 for other links. Will you fix it > or is it design by default? > > Only primary link has valid rx_nss value which is not 0 by below call sta= ck. > ieee80211_assoc_success()-> > =C2=A0=C2=A0=C2=A0 rate_control_rate_init(sta); > > commit:c71420db653aba30a234d1e4cf86dde376e604fa > wifi: mac80211: RCU-ify link STA pointers Strange format and s-o-b missing. Was this meant as an RFC patch? --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes