Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Emmanuel Grumbach <egrumbach@gmail.com>
Cc:     Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
        Gregory Greenman <gregory.greenman@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Ayala Beker <ayala.beker@intel.com>,
        linux-wireless@vger.kernel.org,
        Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgen?= =?utf-8?Q?sen?= 
        <toke@redhat.com>, Golan Ben Ami <golan.ben.ami@intel.com>
Subject: Re: [PATCH] iwlwifi: Mark IWLMEI as broken
References: <20220907134450.1183045-1-toke@toke.dk>
        <CANUX_P3NRqD2YWfkFri37F982QVaCASfyz2qaicGjc9wJ6mDYQ@mail.gmail.com>
Date:   Mon, 12 Sep 2022 14:19:24 +0300
In-Reply-To: <CANUX_P3NRqD2YWfkFri37F982QVaCASfyz2qaicGjc9wJ6mDYQ@mail.gmail.com>
        (Emmanuel Grumbach's message of "Thu, 8 Sep 2022 11:27:41 +0300")
Message-ID: <871qsg96wz.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Emmanuel Grumbach <egrumbach@gmail.com> writes:

> On Wed, Sep 7, 2022 at 5:02 PM Toke H=C3=B8iland-J=C3=B8rgensen <toke@tok=
e.dk> wrote:
>>
>> From: Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com>
>>
>> The iwlmei driver breaks iwlwifi when returning from suspend; the bug
>> report[0] has been open for four months now, and now fix seems to be
>> forthcoming. Since just disabling the iwlmei driver works as a workaroun=
d,
>> let's mark the config option as broken until it can be fixed properly.
>>
>> [0] https://bugzilla.kernel.org/show_bug.cgi?id=3D215937
>>
>> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation =
with CSME")
>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com>
>
> I am not very proud of this, to say the least, but unfortunately,
> despite Toke's patience and
> his willingness to provide logs and all, I couldn't find the time to fix =
this.
> We had tested against NetworkManager wpa_s, but not against iwd.

> From the start, we thought distro wouldn't enable this and this is why
> we disabled iwlmei by default.

I'm always saying that a Kconfig option is not a "free pass" for
anything, some people will enable Kconfig options which they don't
understand and they must not break existing features.

> This driver is meant to be used by specific groups that need this and
> they'll know how to enable this driver even if it is marked as BROKEN.

This is just a temporary solution to workaround the regression. But we
cannot have broken code forever, so I hope this is properly fixed soon
so that the workaround can be removed.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes