Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <caf04e03-6cf3-5f56-da0b-ab68d58e7409@quicinc.com>
Date:   Wed, 14 Sep 2022 20:54:33 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] orinoco: fix repeated words in comments
Content-Language: en-US
To:     Jilin Yuan <yuanjilin@cdjrlc.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
CC:     <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220915030201.35984-1-yuanjilin@cdjrlc.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20220915030201.35984-1-yuanjilin@cdjrlc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/14/2022 8:02 PM, Jilin Yuan wrote:
> Delete the redundant word 'this'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
>   drivers/net/wireless/intersil/orinoco/main.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intersil/orinoco/main.h b/drivers/net/wireless/intersil/orinoco/main.h
> index 5a8fec26136e..852e1643dad2 100644
> --- a/drivers/net/wireless/intersil/orinoco/main.h
> +++ b/drivers/net/wireless/intersil/orinoco/main.h
> @@ -12,7 +12,7 @@
>   /* Compile time configuration and compatibility stuff               */
>   /********************************************************************/
>   
> -/* We do this this way to avoid ifdefs in the actual code */
> +/* We do this way to avoid ifdefs in the actual code */

In this case the two instances of "this" are not a repetition, they are 
different parts of speech.

The existing sentence is correct English; the modified sentence is not.

If the repeated word really bothers you then insert "in": We do this in 
this way...


>   #ifdef WIRELESS_SPY
>   #define SPY_NUMBER(priv)	(priv->spy_data.spy_number)
>   #else