Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp593608rwn; Thu, 15 Sep 2022 03:43:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR5eDQKd4Zm9I7qrucYGAWKeSXpoFXV7vsAVTH/Z0H8dh2IuA9gNxt1z7dN22TveaREveAFn X-Received: by 2002:a17:907:a067:b0:77b:9672:3f83 with SMTP id ia7-20020a170907a06700b0077b96723f83mr16538197ejc.523.1663238604992; Thu, 15 Sep 2022 03:43:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663238604; cv=none; d=google.com; s=arc-20160816; b=vg+KYR7XYcivdj5rcCoE9XYRZW2DOt2dpxk9THwE952jWCRBTdXCnt/aFpMf1iWyLl nASUKKs+V//B7iyBbtk6g63lLxnnzT32MQOdAQNIk1VE6I4W/A031wy39B53sqgWTUmz lMGSmpIrumaaacWeaERG7kzs4BjMouaYUrWuzn+GJo9KvnrZMnnM8CLzkKo+m1f1emI6 A7CvcLsFLt+KQ1gDcPoNOQnCucYW/lZQMCAgxBt0Py+/cxjGzRO/5X2ofzJlDJ60DsAn pSTT+CW0Plb3PqpVKbJpcLQYCT5l6hvfSR5/Yhjl0QiX9v+YwZI9YhLv/Tuk9E6KOgLR eCXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=W2PVGSLYVhYVOYUgzEaxtuM8dru19YpOrdE26sSaX1w=; b=NnGYyiu8UtMxOt/t/E5vOci0G4Utw2ByzlDYIuepjABpBsSLptF40JMjrF2tx+a+t2 wXCaBDB0r0WmUu329LPAZljjITiDo7A9tj6BmwhQwy6xTZzcr5PFEV8dBlt8LwLIG0MV YI5BtX/IRlIZbZNS20urdBNikvFUrShrxuc457ETmUXKGvvAK2704QJZg1b8cP8E83jb F376j5pNOHBnbIyRUdIcrvOKSrUtIlVsdQf3Wy2MUTCyLJyU8+Mvgx+PJ9rJ2mrPw21A XK7l52+nj3IauU9AiNsBtogk4zJDcnwfHhaYMliN+P38CHvy1Gx+072kmLwEIu6bnKl6 34oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=A0VQiNMb; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hd19-20020a170907969300b0077d8a49f36dsi9947679ejc.691.2022.09.15.03.43.07; Thu, 15 Sep 2022 03:43:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=A0VQiNMb; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229704AbiIOKhr (ORCPT + 64 others); Thu, 15 Sep 2022 06:37:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbiIOKhp (ORCPT ); Thu, 15 Sep 2022 06:37:45 -0400 Received: from nbd.name (nbd.name [46.4.11.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDCEB785B8 for ; Thu, 15 Sep 2022 03:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=W2PVGSLYVhYVOYUgzEaxtuM8dru19YpOrdE26sSaX1w=; b=A0VQiNMbNAnJmdTCXR8w1VN7XY qzZTz2HSFrmn/JKzmERQ1WNV0KSA26Lw/1aZWplWdux02R2SsS0h1i/pR4jgnFT2Qx8COJ24Z2zoO 6/4t5pLBXDabt2TTTTYLLOKZIwYRjcoM3xrm98uinQbAdqhJbFFDv+n32uLZ2Uni8sTA=; Received: from p200300daa7301d00b82a348903aff2a7.dip0.t-ipconnect.de ([2003:da:a730:1d00:b82a:3489:3af:f2a7] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1oYmFM-0058hv-1R; Thu, 15 Sep 2022 12:37:28 +0200 Message-ID: <982053de-7bc0-0d4e-9eb7-9da0be559058@nbd.name> Date: Thu, 15 Sep 2022 12:37:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2] mt76: mt7921: fix antenna signal are way off in monitor mode Content-Language: en-US To: sean.wang@mediatek.com, lorenzo.bianconi@redhat.com Cc: Soul.Huang@mediatek.com, YN.Chen@mediatek.com, Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com, Deren.Wu@mediatek.com, km.lin@mediatek.com, jenhao.yang@mediatek.com, robin.chiu@mediatek.com, Eddie.Chen@mediatek.com, ch.yeh@mediatek.com, posh.sun@mediatek.com, ted.huang@mediatek.com, Stella.Chang@mediatek.com, Tom.Chou@mediatek.com, steve.lee@mediatek.com, jsiuda@google.com, frankgor@google.com, kuabhs@google.com, druth@google.com, abhishekpandit@google.com, shawnku@google.com, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org References: <0f95fcdb8511ec765040c8fe85c1fa09437e8ef5.1659574985.git.objelf@gmail.com> From: Felix Fietkau In-Reply-To: <0f95fcdb8511ec765040c8fe85c1fa09437e8ef5.1659574985.git.objelf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 04.08.22 03:07, sean.wang@mediatek.com wrote: > From: Sean Wang > > Group 3 in RxD is disabled in monitor mode. We should use the group 5 in > RxD instead to fix antenna signal way off issue, e.g we would see the > incorrect antenna signal value in wireshark. On the other hand, Group 5 > wouldn't be used in STA or AP mode, so the patch shouldn't cause any > harm to those modes. > > Fixes: cbaa0a404f8d ("mt76: mt7921: fix up the monitor mode") > Reported-by: Adrian Granados > Co-developed-by: Deren Wu > Signed-off-by: Deren Wu > Signed-off-by: Sean Wang This patch has been line wrapped and does not apply. Please resend. - Felix