Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Sep 2022 17:13:34 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Ping-Ke Shih <pkshih@realtek.com>,
        Zong-Zhe Yang <kevin_yang@realtek.com>
Cc:     Kalle Valo <kvalo@kernel.org>,
        Zong-Zhe Yang <kevin_yang@realtek.com>,
        linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] wifi: rtw89: uninitialized variable on error in
 rtw89_early_fw_feature_recognize()
Message-ID: <YyMzDtX/3fUBnonC@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LaQ0lWSgqBqq5C4jTe+FPK/xatIr5YbjOMPW7c+6P7KnidRIkuRmVj2z8CAO?=
 =?us-ascii?Q?C9jhISEzsYoTb6iF5amuKuh1mqh+cB1j7qxD8fHrbU0hx1dTphGv8W2ObxZ5?=
 =?us-ascii?Q?pd1itU8fJNegiVxLWzCXY8Rtrqv3Z6HqYSdt7Dtb7AxjOFYCg2Zc18MlZZDe?=
 =?us-ascii?Q?x4dO+2H1s39H035+aHkhYBS2Q9E9oQteywLXVngllJMlovI4E44pMyBXWYJ/?=
 =?us-ascii?Q?hvuC9jSY2KdWymKed5a5jsmiugLknHlF/Yyb9+5A9+QLjpGrJohR2rg87olT?=
 =?us-ascii?Q?CJBpHgPUklzMLRREa2l7pDkGkkuSWvnxvV15ZQ0mGuUYrow4+McP407U8NV3?=
 =?us-ascii?Q?vYIzfE4CiCZHa5loPX1hKTEVJxGRkH8yrh1mfUV2J0zUDuuYi5DwJEtyDFww?=
 =?us-ascii?Q?PHT5uW7eyWxTngF2EFAvFToTE728Fi0sBRvMnJl7axfIane2NABBck1ls+zh?=
 =?us-ascii?Q?+iMUN+S1vPELrPh+Z/H4zrkOdc8uEWA8QgQOBAddJtCxbp0qEDD4fYg++c4i?=
 =?us-ascii?Q?Og7oHLfUw4KPUJXq/gpvwrxCHF4tsnyCVZii2LBOcJ4qp0Yw/qwVgr3UUuLJ?=
 =?us-ascii?Q?3wX3UHhZS1fRJOAgOikyJVer2JBk4OZQd0Rd08KJnEIWgIe4/f2hhdux9GZP?=
 =?us-ascii?Q?16Oqez1WwkRJQ9uhLk1oaDQTNe8c1BxOfz1noyJZ/YhwL/znGWz73jNbZoV3?=
 =?us-ascii?Q?pEkudh/DiIdK078vwEpRGUYVxxDK94HkzSsSJHLW47/EV4dwnx+Zc4ibH4I3?=
 =?us-ascii?Q?dLHfrDlF3DLQuEfOcFGWnsd9XGf5H6J3H7YbWkGsFk3v36UCM4u6R9oEQ1Sf?=
 =?us-ascii?Q?fQEiwOSMi3KpRooeA/YyuX70M3j1Kunzafr25/Ua68B051qaqA1cIq5d8iVO?=
 =?us-ascii?Q?Enm0L6jDoxKgiUx9tuwv1OSoABoHyNJ/5gSgrtxpCnK1Y5vtix2Mvnw+ITne?=
 =?us-ascii?Q?ccwI1492sseiL1B4u+AnFimNJvTIsc7+BMSvXsMIlcqELEm9FzoKyMFldjxp?=
 =?us-ascii?Q?ThwLFoUjz89LXswp4UcMCaEtzG0QDRuexnRBqA+8ia4vMqN8zsCAOsRcgg9C?=
 =?us-ascii?Q?d3oT0Pj/Hv08g8jdhOuXdn9tFyKfUNDC/ivWFTFaVOYDtE2Lik8ur0F+GYes?=
 =?us-ascii?Q?QUTKLQqfRrnp+DsZtHfnUMvn56/E3TZEuOr7x9hK2029qggBZAXK8WGc9jV0?=
 =?us-ascii?Q?Iyf//CH4eLvDxKUh1cj8/F1iIfp5iLIgYX4aimGAxtGVWRN+WItNrI5ENWmq?=
 =?us-ascii?Q?mi+/DTFdQe0nVkQYmNDSeqk7qWxqXGmaX2qyXKWRxAsnn44T7krVPFfvNQDA?=
 =?us-ascii?Q?tTshaFU0OiEpJAHiuhDoLQENEfP0WSEAEp+tUbLHJYKoDpSWsZyVMSEuk9vH?=
 =?us-ascii?Q?rLlBilBE3BRlZeibO3+Zg2vR5uX0rK1FTofy2GYXEeXeQXXYUbAAASNSCPwE?=
 =?us-ascii?Q?AJZ9SXj1yTNEz0t1L3Ukpf2P3M2jCyBGM0FzlW1Ivu1xSBMeA/oWaoF93O3f?=
 =?us-ascii?Q?NNJL0zd+d1UkyIFYGObB24IYTdoTAqYWf3WK9wpV/d2Nc3FQbhSDiCZlEj/y?=
 =?us-ascii?Q?RZvQsLwNt8Y7LtCTFsXhDHRqB6y9IoyBSosRpogwafTKr+/hpVlsw2/7kfZO?=
 =?us-ascii?Q?Kg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 534e608d-ddb8-4196-43ac-08da97247e0f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 14:13:41.7142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KmVAJsH3elCsytUjjXuxFT+eupi8H3XyOL6zYaDckshvBs4UB5nkEJ1C0l1sq0w6ZdJjsQ8d6QRaGnsr/BC3O+FXkf5VXAuSXd6rd26ebJM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5156
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-15_08,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 adultscore=0
 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2208220000
 definitions=main-2209150083
X-Proofpoint-ORIG-GUID: JZlRwbvNM532IAs9Hx2EZriFMenvifmN
X-Proofpoint-GUID: JZlRwbvNM532IAs9Hx2EZriFMenvifmN
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

If request_partial_firmware_into_buf() fails then "firmware" is not
initialized and the release_firmware(firmware) will crash.

Fixes: deebea35d699 ("wifi: rtw89: early recognize FW feature to decide if chanctx")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/wireless/realtek/rtw89/fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 8e4d0e18fa71..2be70b907762 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -268,7 +268,7 @@ void rtw89_early_fw_feature_recognize(struct device *device,
 						device, &buf, sizeof(buf), 0);
 	if (ret) {
 		dev_err(device, "failed to early request firmware: %d\n", ret);
-		goto out;
+		return;
 	}
 
 	ver_code = buf.mfw_hdr.sig != RTW89_MFW_SIG ?
-- 
2.35.1