Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Sep 2022 20:56:08 +0200
From:   Stanislaw Gruszka <stf_xl@wp.pl>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Helmut Schaa <helmut.schaa@googlemail.com>,
        Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] wifi: rt2x00: Fix "Error - Attempt to send packet
 over invalid queue 2"
Message-ID: <20220915185608.GA10590@wp.pl>
References: <20220908173618.155291-1-hdegoede@redhat.com>
 <20220908173618.155291-2-hdegoede@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220908173618.155291-2-hdegoede@redhat.com>
Precedence: bulk

On Thu, Sep 08, 2022 at 07:36:18PM +0200, Hans de Goede wrote:
> Even though ieee80211_hw.queues is set to 2, the ralink rt2x00 driver
> is seeing tx skbs submitted to it with the queue-id set to 2 / set to
> IEEE80211_AC_BE on a rt2500 card when associating with an access-point.

I'm impressed you have still working rt2500 card :-)
 
> This causes rt2x00queue_get_tx_queue() to return NULL and the following
> error to be logged: "ieee80211 phy0: rt2x00mac_tx: Error - Attempt to
> send packet over invalid queue 2", after which association with the AP
> fails.
> 
> This patch works around this by mapping QID_AC_BE and QID_AC_BK
> to QID_AC_VI when there are only 2 tx_queues.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>