Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0b342479-d04a-a45e-d63b-73eec5a1fb40@wetzel-home.de>
Date:   Thu, 15 Sep 2022 22:06:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH] mac80211: Ensure vif queues are operational after start
Content-Language: en-US
From:   Alexander Wetzel <alexander@wetzel-home.de>
To:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Cc:     Johannes Berg <johannes@sipsolutions.net>
References: <20220915130946.302803-1-alexander@wetzel-home.de>
 <26e9ae91-8e13-df45-815c-cb45c1911032@nbd.name>
 <9e36f219-14a6-8960-a5fd-cb9f708237ed@wetzel-home.de>
In-Reply-To: <9e36f219-14a6-8960-a5fd-cb9f708237ed@wetzel-home.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

> 
> I've got some doubts that my fix is correct...
> While it fixes the problem in my tests it looks like we'll need another 
> queue restart to get the queues working again.
> 
> After all IEEE80211_TXQ_STOP_NETIF_TX will not be cleared when it has 
> been set by __ieee80211_stop_queue().
> 
> I'll update the patch and skip setting vif.txqs_stopped when 
> SDATA_STATE_RUNNING is not set. Not having IEEE80211_TXQ_STOP_NETIF_TX 
> set looks harmless, having it set when it should less problematic...

Scratch that: The patch should be ok as it is: 
IEEE80211_TXQ_STOP_NETIF_TX is not set on stop, the patch should be ok 
as it is.

Sorry for the noise.

Alexander