Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1723692rwn; Thu, 15 Sep 2022 22:52:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7sbVIAe/4VUSlmGC1u5ir6zXApFgflpavLJw5ZU8jO3X73V3LSenEE5fog/LXe7gRIMR19 X-Received: by 2002:a17:906:9bd3:b0:778:c8e0:fcee with SMTP id de19-20020a1709069bd300b00778c8e0fceemr2359001ejc.275.1663307559618; Thu, 15 Sep 2022 22:52:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663307559; cv=none; d=google.com; s=arc-20160816; b=nQWwklKQ7BgOdEbyOd73jrYqXVHhQQWYAa5AeHfOaaqmdCNvlc+P5g55aRb08C/IOs B1ZgG+bvlkU7/+N5e8DHxZqBK16oA/bQWneMavOkcgSq1DZPYLj/yFb48zEXMFJs7YwC FdVF+vr5ogvjWoZGAYKjS3nNH+ZlSD1bGv9bfjljFRWY3ZyEsBo4fDVSnpaMa7bi3VVH AkH3d5IBtleZz+N3bq2fKS8ENlNpkgPoQHSMrJZGkJO7F+LZH0eVHHm4zVfO2vDzT5JC K6P10prZBJ3JCEIgSbmOF009Qb2WTpp1vObzQe9t7jawBQc7I/+hE/daT48JNUxYG7BU dPJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=GxKvSLvQYSH+KYSr+i/dVt/jFIpr6dhHCAF64Jm4eS0=; b=W/vZ0HjbLe7DzPxuE/kvWGZSD4TQWiVsCwiSeITP2v5sfPF+/iPkX3SrciKNd15NR5 p8nEywpLHDKOWJKDWadcqSaaorSVXw22KKa3yIcguzp5yyGTc0+JaJt2+hDnctT/ZIB8 9Yeoww14fYCzkQgB6cIAAPpoahRPJwlCJf2sVnYOpXn18bGh3PKCz7R27ROxl6TXMvmI b05/VL0d3ESol1pK2vKefVOc+fhvAjADIR+jpFk6UFPEO32kXq9TDvuhq3BrjdfJ+gVe msH7y5vH2bytcIfuZDzNMl/6NZqtB1pArUpIHZKETsCMFd4JVtIAefpHUug2G+tHiCUT Aujg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Smf2uhH/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd12-20020a1709076e0c00b0078033da6c02si5509626ejc.576.2022.09.15.22.52.18; Thu, 15 Sep 2022 22:52:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Smf2uhH/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbiIPFhU (ORCPT + 64 others); Fri, 16 Sep 2022 01:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbiIPFhT (ORCPT ); Fri, 16 Sep 2022 01:37:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 367E56F56B for ; Thu, 15 Sep 2022 22:37:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9F76AB823AE for ; Fri, 16 Sep 2022 05:37:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB342C433C1; Fri, 16 Sep 2022 05:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663306635; bh=jM5saF8A2jQF85Jq+EzNXODocbAeHuLf4n0rQwVxZlo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Smf2uhH/NHhercMlEbVhAZ7OFahC35FBj7VSPD8BLfXVIsx4AeKb+pLgxupUxJT5Y +DdisgxqyoafWZkhCj1xh0t3MsNbzhN2BHRDfDe3PvNz+X34AHkwulQbLhMOsIvzGJ fN5nYnNGBKT3ZAHzOrZvBtvO18UQLvcd76MMdymAwSWdAxjzg1ypXGTESt91J1zJ6A edLw/4T+P4oRE0cHrNSG2sUmW3GM7FM0DRtvwmjA1D6vRM9/9o013hFklas3WlR756 SaqHfdrb1C4j/5svet+YZ54nHXPhht417Ex9TpkIpLdK6piNpntTx2lsAMZ4lXFUBS EIiOBulJb8vfA== From: Kalle Valo To: Felix Fietkau Cc: sean.wang@mediatek.com, lorenzo.bianconi@redhat.com, Soul.Huang@mediatek.com, YN.Chen@mediatek.com, Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com, Deren.Wu@mediatek.com, km.lin@mediatek.com, jenhao.yang@mediatek.com, robin.chiu@mediatek.com, Eddie.Chen@mediatek.com, ch.yeh@mediatek.com, posh.sun@mediatek.com, ted.huang@mediatek.com, Stella.Chang@mediatek.com, Tom.Chou@mediatek.com, steve.lee@mediatek.com, jsiuda@google.com, frankgor@google.com, kuabhs@google.com, druth@google.com, abhishekpandit@google.com, shawnku@google.com, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2] mt76: mt7921: fix antenna signal are way off in monitor mode References: <0f95fcdb8511ec765040c8fe85c1fa09437e8ef5.1659574985.git.objelf@gmail.com> <982053de-7bc0-0d4e-9eb7-9da0be559058@nbd.name> Date: Fri, 16 Sep 2022 08:37:07 +0300 In-Reply-To: <982053de-7bc0-0d4e-9eb7-9da0be559058@nbd.name> (Felix Fietkau's message of "Thu, 15 Sep 2022 12:37:27 +0200") Message-ID: <8735crc22k.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > On 04.08.22 03:07, sean.wang@mediatek.com wrote: >> From: Sean Wang >> >> Group 3 in RxD is disabled in monitor mode. We should use the group 5 in >> RxD instead to fix antenna signal way off issue, e.g we would see the >> incorrect antenna signal value in wireshark. On the other hand, Group 5 >> wouldn't be used in STA or AP mode, so the patch shouldn't cause any >> harm to those modes. >> >> Fixes: cbaa0a404f8d ("mt76: mt7921: fix up the monitor mode") >> Reported-by: Adrian Granados >> Co-developed-by: Deren Wu >> Signed-off-by: Deren Wu >> Signed-off-by: Sean Wang > > This patch has been line wrapped and does not apply. Please resend. And please use "wifi:" in the title. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches