Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     James Prestwood <prestwoj@gmail.com>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] net: mac80211: remove/avoid misleading prints
References: <20220915195553.1052931-1-prestwoj@gmail.com>
Date:   Fri, 16 Sep 2022 08:44:17 +0300
In-Reply-To: <20220915195553.1052931-1-prestwoj@gmail.com> (James Prestwood's
        message of "Thu, 15 Sep 2022 12:55:53 -0700")
Message-ID: <87pmfvan66.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

James Prestwood <prestwoj@gmail.com> writes:

> At some point a few kernel debug prints started appearing which
> indicated something was sending invalid IEs:
>
> "bad VHT capabilities, disabling VHT"
> "Invalid HE elem, Disable HE"
>
> Turns out these were being printed because the local hardware
> supported HE/VHT but the peer/AP did not. Bad/invalid indicates,
> to me at least, that the IE is in some way malformed, not missing.
>
> For the HE print (ieee80211_verify_peer_he_mcs_support) it will
> now silently fail if the HE capability element is missing (still
> prints if the element size is wrong).
>
> For the VHT print, it has been removed completely and will silently
> set the DISABLE_VHT flag which is consistent with how DISABLE_HT
> is set.
>
> Signed-off-by: James Prestwood <prestwoj@gmail.com>

This has been cluttering my test logs as well, thanks for fixing this.
But the title should be:

wifi: mac80211: remove/avoid misleading prints

I assume Johannes can fix it during commit.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches