Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     cgel.zte@gmail.com
Cc:     chunkeey@googlemail.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] carl9170: use strscpy() is more robust and safer
In-Reply-To: <20220916063047.155021-1-chi.minghao@zte.com.cn> (cgel zte's
        message of "Fri, 16 Sep 2022 06:30:47 +0000")
References: <20220916063047.155021-1-chi.minghao@zte.com.cn>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Date:   Fri, 16 Sep 2022 11:48:42 +0300
Message-ID: <87k0637lhx.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

cgel.zte@gmail.com writes:

> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
>
> That's now the recommended way to copy NUL terminated strings.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>  drivers/net/wireless/ath/carl9170/fw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/fw.c b/drivers/net/wireless/ath/carl9170/fw.c
> index 1ab09e1c9ec5..4c1aecd1163c 100644
> --- a/drivers/net/wireless/ath/carl9170/fw.c
> +++ b/drivers/net/wireless/ath/carl9170/fw.c
> @@ -105,7 +105,7 @@ static void carl9170_fw_info(struct ar9170 *ar)
>  			 CARL9170FW_GET_MONTH(fw_date),
>  			 CARL9170FW_GET_DAY(fw_date));
>  
> -		strlcpy(ar->hw->wiphy->fw_version, motd_desc->release,
> +		strscpy(ar->hw->wiphy->fw_version, motd_desc->release,
>  			sizeof(ar->hw->wiphy->fw_version));

Already changed in:

https://git.kernel.org/netdev/net-next/c/bf99f11df4de

Please use latest trees to avoid duplicate work.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches