Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fe792366-26b8-882e-c5e3-4e124a21e768@redhat.com>
Date:   Fri, 16 Sep 2022 13:32:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH 1/1] wifi: rt2x00: Fix "Error - Attempt to send packet
 over invalid queue 2"
Content-Language: en-US
To:     Stanislaw Gruszka <stf_xl@wp.pl>
Cc:     Helmut Schaa <helmut.schaa@googlemail.com>,
        Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org
References: <20220908173618.155291-1-hdegoede@redhat.com>
 <20220908173618.155291-2-hdegoede@redhat.com> <20220915185608.GA10590@wp.pl>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220915185608.GA10590@wp.pl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 9/15/22 20:56, Stanislaw Gruszka wrote:
> On Thu, Sep 08, 2022 at 07:36:18PM +0200, Hans de Goede wrote:
>> Even though ieee80211_hw.queues is set to 2, the ralink rt2x00 driver
>> is seeing tx skbs submitted to it with the queue-id set to 2 / set to
>> IEEE80211_AC_BE on a rt2500 card when associating with an access-point.
> 
> I'm impressed you have still working rt2500 card :-)

I recently become the owner of a Turion64 based MSI S270 laptop to test
some kernel code I was refactoring on. This has a mini-pci rt2500 card,
which indeed still works after this fix.

The thing has 2G RAM and even runs a Fedora 37 beta but the CPU is
quite slow and gets pretty toasty.

>> This causes rt2x00queue_get_tx_queue() to return NULL and the following
>> error to be logged: "ieee80211 phy0: rt2x00mac_tx: Error - Attempt to
>> send packet over invalid queue 2", after which association with the AP
>> fails.
>>
>> This patch works around this by mapping QID_AC_BE and QID_AC_BK
>> to QID_AC_VI when there are only 2 tx_queues.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>

Thanks.

Regards,

Hans