Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp304437rwb; Sat, 17 Sep 2022 05:41:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM79n4NL2e5SzFi0qrM7VEQeN2ZBZqgHfMHWziOU90uUG2rNUmci6G/hqd2oeBOyULJWCnCV X-Received: by 2002:a17:902:c7cc:b0:176:9fdd:ddb7 with SMTP id r12-20020a170902c7cc00b001769fddddb7mr4374079pla.150.1663418478291; Sat, 17 Sep 2022 05:41:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663418478; cv=none; d=google.com; s=arc-20160816; b=iidTAFAu9bLRswXAnyM4L3KPPPGrbTb8l7S6OOHQuFZYCtufGsMOoOMUl2fyDuVTkN Zp8eKxZR56BhLs6/rKN/vB+XbYj7yNwSF545OTdvRN9AmTUk9b9QhUJIwZjDEmRXgc4u fdq5F/DMFKslq4pK/pE2TiIo/RpsnRq2YNCVrLZGcGk8oChVtVqZQy92nppnzDMJHBD2 boMb/WdhCTvAcIUINj+mPMdJvYUtpRK6dcfNiXZLMFgvg67yVDcJK5GrO0bO7JSLnQ+E MYtDwdijoFC3E8Kj2qn6/gO76ii8RBzE8P7Tj/e+nBjsO9mfPgPJ1oo+dutGwVvV+YWY Js0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aKm/EaQNbfRNjKUeL6cxNlVfwTJRcDfQt/US7SpF3jQ=; b=FF6XAglsWURj8898tjL8Sf2u+1ayZhys7/91xzgkHyEcooym2wdi5NsiLfEMCuHO+X iE2edPaMAhVFK38AT3Yub1Cgt59yAkZLir3RVyLfaTxEappvazD8d/adMsYzEGyIfywF PxBozxDQbtHdPBZONql0Ur5mbiAiLJ1vf43eimLoYpMV4CYOlTTKK8eKIdVwN3O7VCWl KkFrK6JkRWowteYDEjtqBmCQ8oPTt7MT2MhNeYGsXVA/ysuhmJlDI80NgOKmOYaAG2Y8 M4vlD1VtI9sLQvc6+gJuZNIDPn1TR46ERG1AhhH8KUewiAqNPyBORPkQ+GzO8+mhzxIm F0Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=fsN9+2QB; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c123-20020a633581000000b0042bb0453c2esi26696424pga.532.2022.09.17.05.41.08; Sat, 17 Sep 2022 05:41:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=fsN9+2QB; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbiIQMkY (ORCPT + 64 others); Sat, 17 Sep 2022 08:40:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbiIQMkW (ORCPT ); Sat, 17 Sep 2022 08:40:22 -0400 Received: from mx3.wp.pl (mx3.wp.pl [212.77.101.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D89B825E97 for ; Sat, 17 Sep 2022 05:40:21 -0700 (PDT) Received: (wp-smtpd smtp.wp.pl 30386 invoked from network); 17 Sep 2022 14:40:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1663418419; bh=aKm/EaQNbfRNjKUeL6cxNlVfwTJRcDfQt/US7SpF3jQ=; h=From:To:Cc:Subject; b=fsN9+2QBFZQJ4jeXxCpVFgD0taJQ7UEEbXHho2e4hQnc7TH3ryIAtrw1ysQFMYEvl xCfpazNIkA8YsRVl3X/Vmz/AEe3zCDmkuKGk7KxuW4FgjAlqL8hLbgAoytdPkRUSUu 7vJYM3+1Evp2V64qQfaQYq7quT/+PaQIliMepERU= Received: from 89-64-7-128.dynamic.chello.pl (HELO localhost) (stf_xl@wp.pl@[89.64.7.128]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 17 Sep 2022 14:40:19 +0200 Date: Sat, 17 Sep 2022 14:40:18 +0200 From: Stanislaw Gruszka To: Daniel Golle Cc: linux-wireless@vger.kernel.org, Helmut Schaa , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Johannes Berg Subject: Re: [PATCH 08/15] rt2x00: don't run Rt5592 IQ calibration on MT7620 Message-ID: <20220917124018.GD17901@wp.pl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-WP-MailID: 3feb6dd92423be0b81f7c9838fbac39a X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [sZPU] X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sat, Sep 17, 2022 at 12:06:39AM +0100, Daniel Golle wrote: > The function rt2800_iq_calibrate is intended for Rt5592 only. > Don't call it for MT7620 which has it's own calibration functions. > > Reported-by: Serge Vasilugin > Signed-off-by: Daniel Golle > --- > drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c > index 6e5a72cf2a81a0..55a46e27b59875 100644 > --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c > +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c > @@ -4365,7 +4365,8 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev, > reg = (rf->channel <= 14 ? 0x1c : 0x24) + 2*rt2x00dev->lna_gain; > rt2800_bbp_write_with_rx_chain(rt2x00dev, 66, reg); > > - rt2800_iq_calibrate(rt2x00dev, rf->channel); > + if (!rt2x00_rt(rt2x00dev, RT6352)) Since is needed for rt5992 that check would be more appropriate.