Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp563022rwb; Sat, 17 Sep 2022 10:06:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7aYDAVNZPl7Xl6TMq2RFzGKhnEgv1g0dtnWvdo8BQ5CBcioqlOUWV7HQHY4lii1Zfm85p1 X-Received: by 2002:a17:903:1106:b0:172:68f9:f68 with SMTP id n6-20020a170903110600b0017268f90f68mr5519968plh.50.1663434360495; Sat, 17 Sep 2022 10:06:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663434360; cv=none; d=google.com; s=arc-20160816; b=VyCwD00tSQ+PEn47Q9zLmHEMjJpAw8tkbEzOjpme+VvuxrayiZVnRx8pv9LAiGqiUt GKn/sB63UpZzgyYZEQpDpsQJfkaxdphALnReXuH/+axEjDwEpuDcDsqC4f5+Diu7Waet VHEZApVQQOuuAJyvFFqxGlr68jShIx7x8WgtK0EXIUrmJ762U6bKChti1CP3mq/+090N 4UFOjO3RiB0iTSn8y3vRru+4Rs+ph5KTJWTNIyAjfUgxpjPHCsunpz7go5CB4gQ7HZsT AKKRKRvTjxFaku+SCwFkadj27T4WVsn8h2r3gBKZrSvij24WTqyF3ZomuDQ+wYv+VT9y w66w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=g0KVfK7aqkVGJhDMg0E6en4Ka+l+tJRrOlOJzpcisP4=; b=FPb8rKunmIHUrVkDZ73gxShVixYW4MHdgCq4VNMZq5EgYv4XM+Hq/N+TGI1ST8mEwq M9LmLuFnjkQU7RDf6Xd0QJdO0YgH12ZV0D+oxM8ZzDGPT4msKP9vEU1Md13/99YfUHGW k0tJK3uK40bWD7WlhXWjRuNdaWBYpEZOwVi54I6CITGPXe1hTPdNUDGZYpkoZYDshSTD 5fOcFCOAozQhfkF9hmjb/SS/sKSkNi2PjuntuUpYJOiOYD+82ettaz0mppJqpGFJjbnM pDRpHg0c6/SKheNT0ZdFPJwWoIlzPMwLPR6zfavPzVKeOs/JIbwp1jroVXg19E+6O/jy o4pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n37-20020a635c65000000b004305c4aa3b2si25675880pgm.496.2022.09.17.10.05.52; Sat, 17 Sep 2022 10:06:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbiIQQrn (ORCPT + 64 others); Sat, 17 Sep 2022 12:47:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229702AbiIQQrk (ORCPT ); Sat, 17 Sep 2022 12:47:40 -0400 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2CCA326C4 for ; Sat, 17 Sep 2022 09:47:39 -0700 (PDT) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1oZayf-0002fa-39; Sat, 17 Sep 2022 18:47:38 +0200 Date: Sat, 17 Sep 2022 17:47:27 +0100 From: Daniel Golle To: linux-wireless@vger.kernel.org, Stanislaw Gruszka , Helmut Schaa Cc: Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Johannes Berg Subject: [PATCH v2 09/16] rt2x00: don't run Rt5592 IQ calibration on MT7620 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The function rt2800_iq_calibrate is intended for Rt5592 only. Don't call it for MT7620 which has it's own calibration functions. Reported-by: Serge Vasilugin Signed-off-by: Daniel Golle --- v2: test for RT5592 instead of !RT6352 drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 2dc197b508ad32..f51bf27f9f7942 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c @@ -4398,7 +4398,8 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev, reg = (rf->channel <= 14 ? 0x1c : 0x24) + 2*rt2x00dev->lna_gain; rt2800_bbp_write_with_rx_chain(rt2x00dev, 66, reg); - rt2800_iq_calibrate(rt2x00dev, rf->channel); + if (rt2x00_rt(rt2x00dev, RT5592)) + rt2800_iq_calibrate(rt2x00dev, rf->channel); } if (rt2x00_rt(rt2x00dev, RT6352)) { -- 2.37.3