Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp714843rwb; Sat, 17 Sep 2022 13:29:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4m51xw8ZlsOogf+xMOj1VbOfmQd+MMhDIGpn3aS4NCYsF0sWpDhUOPZNZUUBaaGJKc+MEi X-Received: by 2002:a05:6a00:1a44:b0:52a:ecd5:bbef with SMTP id h4-20020a056a001a4400b0052aecd5bbefmr11240119pfv.28.1663446557525; Sat, 17 Sep 2022 13:29:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663446557; cv=none; d=google.com; s=arc-20160816; b=G2ZkAyx6qkcN+/coeQXYwBoZNh7DyVieoPSLrM9bw8yynaMvH5VDTJuUdDr9EvYvBa X637PaDRb+xVJyJAMmkfW0UFzTaI0u9dCErgLzDtcOKwU34REEOssWUqSwkcgqzL9WA9 BKAdeii37tpo/fjy6bkmjzYBPljot0TWUZ1C7qHf0+uUbEsas4RBshKBibglZ8UmG0/1 l7l+swjgZJGQo8tzN8+GqNBwFJfcwK7t2L4raK6zVUDe9Bs+7ceQm2r6kkp3tBpW1jiU qih8JVvG/7PC361Y9EPd0bMJVqq+HlW5nQn8iZ6rriV1ui8T+PpTpcfnNrD++ndsPaAd zoIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=bhaojDW1QqF9z9VRvanuSHPvOD9QWRHQ/r2v73iZRTc=; b=IScgS9rE4help8k79x6DLl0MtncQnh9EzPkcGbxH2XZ/GngQzSIboGg/IxAwGCVlfe nnikg77YmAxcd4txTBAAtXTRLVnXDGVYzcHzbxAIrq1Y2Oabf8WxEXBX+wIcDQYPkA0p f07FoBoyu9IXVFNJvvd5+Dn0SbACWgnCr/7mF4IYqXDWu0YFN0XhzTZyKioOlgz6gjJh 0zDUeBiVkzMovms8GeGkATmUVn2QDuxD5SJQ66GmWE/fSGlJM1OJLI87KW2KsjNupLAq 8P2PIS2KotJhiuPLu+fYUZ+jqxO8OcbW6c25JKskEpkrS2ZefB/ZbYZnm6hPOC56mBV4 ikog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a170902e80b00b001782ca7fb20si21452378plg.33.2022.09.17.13.29.09; Sat, 17 Sep 2022 13:29:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229566AbiIQU2i (ORCPT + 64 others); Sat, 17 Sep 2022 16:28:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbiIQU2h (ORCPT ); Sat, 17 Sep 2022 16:28:37 -0400 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF6152ED74 for ; Sat, 17 Sep 2022 13:28:36 -0700 (PDT) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1oZeQU-0003pN-3C; Sat, 17 Sep 2022 22:28:35 +0200 Date: Sat, 17 Sep 2022 21:28:29 +0100 From: Daniel Golle To: linux-wireless@vger.kernel.org, Stanislaw Gruszka , Helmut Schaa Cc: Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Johannes Berg Subject: [PATCH v3 09/16] rt2x00: don't run Rt5592 IQ calibration on MT7620 Message-ID: <31a1c34ddbd296b82f38c18c9ae7339059215fdc.1663445157.git.daniel@makrotopia.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The function rt2800_iq_calibrate is intended for Rt5592 only. Don't call it for MT7620 which has it's own calibration functions. Reported-by: Serge Vasilugin Signed-off-by: Daniel Golle --- v2: test for RT5592 instead of !RT6352 drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 2dc197b508ad32..4b912b362562c9 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c @@ -4398,7 +4398,8 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev, reg = (rf->channel <= 14 ? 0x1c : 0x24) + 2*rt2x00dev->lna_gain; rt2800_bbp_write_with_rx_chain(rt2x00dev, 66, reg); - rt2800_iq_calibrate(rt2x00dev, rf->channel); + if (rt2x00_rt(rt2x00dev, RT5592)) + rt2800_iq_calibrate(rt2x00dev, rf->channel); } if (rt2x00_rt(rt2x00dev, RT6352)) { -- 2.37.3