Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2315074rwb; Mon, 19 Sep 2022 03:18:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4AFSqmtoqJXlQERY/OrsI73Yk6w1A8aq7uqna1p7s8SajNE3CgSICHcXrV9WMOeb81eDee X-Received: by 2002:a17:90b:1905:b0:202:cbf9:cd76 with SMTP id mp5-20020a17090b190500b00202cbf9cd76mr19624998pjb.171.1663582701175; Mon, 19 Sep 2022 03:18:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663582701; cv=none; d=google.com; s=arc-20160816; b=pC9wH60k6GdOLBjxz/TLAhknA5sG+6jZiGrCkTc+p7LlK2kl1S5B36TaJYx99Lp8WI n/qVDKo61bNSDtpk6TZsVGBWJy1o/YDwWPAZ5FdPdD5QQR7DrELqvsj5wWYGgnljUxGV Xcc9vfEHPYoXs9g7nBjFT2CmYI4F4q8TvQzdk/sJNOYfqz3gPSk0dTJ3HQVNweIMJeXl 9Zrh7jZSksg2iRjIMZsWqBbfpg1KLqpQTRXLcTppGiCmypgVJLwpjTRJXF1uZ2zMVS+9 ubJf029IsaM71oLLeX/XZ+/+pH4S3/rAeUybSY6YuzbGDM8+o93mXS6wL8esgitbFucW ygyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=8qgkmBvvtFV/P5YEfHnpE4LfwkFsFOX3xTS43VQKNlU=; b=a1oesB+RTX5CO+68Saf4RrlpJQhVkQwJwMpP+NoUXJ3oQTe63tuoVx5WOoHzxAn9dl NAw77YvruNvQqvZDVt/o+VoRxvCVWkTe2FzZyNi8Zo/e6Pexjtj4G4B5VggYRa7AzWUj l5DLG3CKo14amxaQGAJaEnKFaOYRKoh25KR/cLxw/Wh8QjMpNjU7IKqiNZROHVBJ7FNv U7EGSeSFtGz79RrEYo7Ea+ulRZzMHdImCDWhyxkFCkoX/i2+LLAKtyXVEjwWiuu2yeZ5 gDR6rxvQJy9vAB3AYsbkWuakihVtUMWG55pBbjhAlOmE58S9p3ArumIKaJCdNCftstzQ L9Bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NVQirFPz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h13-20020a170902f54d00b00172debe1681si33631079plf.45.2022.09.19.03.18.12; Mon, 19 Sep 2022 03:18:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NVQirFPz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229823AbiISKJW (ORCPT + 63 others); Mon, 19 Sep 2022 06:09:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbiISKJP (ORCPT ); Mon, 19 Sep 2022 06:09:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 587DE237C4 for ; Mon, 19 Sep 2022 03:09:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B4537B80B31 for ; Mon, 19 Sep 2022 10:09:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4281BC433C1; Mon, 19 Sep 2022 10:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663582151; bh=wu9PhEwqplD47bFcvlR5s1vacQQ7TmZ98w6otRd5H7w=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=NVQirFPz5XrfzfdwcadSRi3UyCdLER8HFEAump8vTPwmBsZ4yfLvfegSM0/44Nghg TUqDosAce0dCYkq0fqkuv2w18A4SGjJXpbisspdJZVnxetpZjKjR08EDJi0hazwcb+ 9zoJaQdpR0+lBCZtl6nnVo3Rd5wcvkXfFjuX8N0tCV0Rmw2G9p7CE6SKy/4aa4MuOv r1vm3Cg/Q4CnnSw59kd+mfkT32a4UH+cCQZXs+h6U0DU+lXJgeIyxUu+E6MNqGjRGd F8m4jKesD/RJ+LIPslSbfkm76T+kxvCckvE8rQMfWT+DQx3PBMNA2Zk+UDCJUN9yjd TvAoPtMT0wXpg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/1] wifi: rt2x00: Fix "Error - Attempt to send packet over invalid queue 2" From: Kalle Valo In-Reply-To: <20220908173618.155291-2-hdegoede@redhat.com> References: <20220908173618.155291-2-hdegoede@redhat.com> To: Hans de Goede Cc: Stanislaw Gruszka , Helmut Schaa , Hans de Goede , linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166358214839.24821.10030211183220172513.kvalo@kernel.org> Date: Mon, 19 Sep 2022 10:09:10 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hans de Goede wrote: > Even though ieee80211_hw.queues is set to 2, the ralink rt2x00 driver > is seeing tx skbs submitted to it with the queue-id set to 2 / set to > IEEE80211_AC_BE on a rt2500 card when associating with an access-point. > > This causes rt2x00queue_get_tx_queue() to return NULL and the following > error to be logged: "ieee80211 phy0: rt2x00mac_tx: Error - Attempt to > send packet over invalid queue 2", after which association with the AP > fails. > > This patch works around this by mapping QID_AC_BE and QID_AC_BK > to QID_AC_VI when there are only 2 tx_queues. > > Signed-off-by: Hans de Goede > Acked-by: Stanislaw Gruszka Patch applied to wireless-next.git, thanks. f2c6e7ca3ee6 wifi: rt2x00: Fix "Error - Attempt to send packet over invalid queue 2" -- https://patchwork.kernel.org/project/linux-wireless/patch/20220908173618.155291-2-hdegoede@redhat.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches